Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/multiple accounts migration #6046

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

camilasan
Copy link
Member

Multiple legacy accounts migration was not correctly migrating all folders for each account.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #6046 (a7cb8d2) into master (e2bd6e5) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6046   +/-   ##
=======================================
  Coverage   60.13%   60.14%           
=======================================
  Files         145      145           
  Lines       18873    18873           
=======================================
+ Hits        11350    11351    +1     
+ Misses       7523     7522    -1     

see 1 file with indirect coverage changes

@camilasan camilasan requested review from mgallien, claucambra and allexzander and removed request for mgallien September 12, 2023 19:46
@camilasan camilasan force-pushed the bugfix/multiple-accounts-migration branch 2 times, most recently from b48bd77 to 0d558c9 Compare September 13, 2023 09:52
@camilasan camilasan enabled auto-merge September 13, 2023 09:52
Camila added 2 commits September 13, 2023 07:18
Also cleans up FolderMan::setupFolderFromOldConfigFile logic.

Signed-off-by: Camila <[email protected]>
@camilasan camilasan force-pushed the bugfix/multiple-accounts-migration branch from 0d558c9 to a7cb8d2 Compare September 13, 2023 10:18
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6046-a7cb8d2ca298378151539e8043f58a4455beca87-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@camilasan camilasan merged commit 8e54689 into master Sep 13, 2023
11 of 12 checks passed
@camilasan camilasan deleted the bugfix/multiple-accounts-migration branch September 13, 2023 10:48
@mgallien
Copy link
Collaborator

/backport to stable-3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants