Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.10] Fix macOS notification talk replies by avoiding early dealloc #6037

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #6034

@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.10.0 milestone Sep 7, 2023
@mgallien mgallien enabled auto-merge September 7, 2023 11:54
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #6037 (5ea644d) into stable-3.10 (80be0be) will increase coverage by 0.01%.
Report is 3 commits behind head on stable-3.10.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff               @@
##           stable-3.10    #6037      +/-   ##
===============================================
+ Coverage        60.14%   60.16%   +0.01%     
===============================================
  Files              145      145              
  Lines            18868    18868              
===============================================
+ Hits             11349    11352       +3     
+ Misses            7519     7516       -3     

see 3 files with indirect coverage changes

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6037-5ea644d220dc47821d47d978f3b521b5b4d17b29-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit bfacf45 into stable-3.10 Sep 7, 2023
12 checks passed
@mgallien mgallien deleted the backport/6034/stable-3.10 branch September 7, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants