fixed detection of server version in cmd client similar to gui client (2nd try, signed off)

[errror]

first check status.php for version and then capabilities, only use version string if not empty

this also fixes 'File names containing the character ":" are not supported on this file system.' errors in nextcloudcmd (on Linux): The invalidFilenameRegex was set to a static default in case the server version was not set correctly. As newer versions of nextcloud do not return the version in capabilities but status.php, the server version was empty.

As I did not find a way to fullfil your requirements in my first PR, I created a new one. This one has a commit message with a correct Signed-off line. It also has no other changes as I did not enable the actions in this fork.

[claucambra]

Thanks for the changes!

[codecov]

Codecov Report

Merging #6023 (b1db1fb) into master (23d324b) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6023   +/-   ##
=======================================
  Coverage   60.14%   60.15%           
=======================================
  Files         145      145           
  Lines       18868    18868           
=======================================
+ Hits        11349    11350    +1     
+ Misses       7519     7518    -1     

see 1 file with indirect coverage changes

[claucambra]

In updating the branch you have added a merge commit -- please don't update the contents of the PR with the "Update branch" button as this adds merge commits to your pull request

Once you have removed the merge commit, we will be able to merge

[errror]

In updating the branch you have added a merge commit -- please don't update the contents of the PR with the "Update branch" button as this adds merge commits to your pull request

ok, will remember this for the future.

Once you have removed the merge commit, we will be able to merge

I have removed the merge commit!

[claucambra]

In updating the branch you have added a merge commit -- please don't update the contents of the PR with the "Update branch" button as this adds merge commits to your pull request

ok, will remember this for the future.

Once you have removed the merge commit, we will be able to merge

I have removed the merge commit!

Thanks!

One last thing -- the sign-off points to [email protected] but it seems your commit is in fact authored under the email [email protected]. Could you amend the commit and either A) modify the signed-off-by OR B) modify your author email in the commit?

This will allow our CI pipeline to pass and we can merge the PR

[errror]

One last thing -- the sign-off points to [email protected] but it seems your commit is in fact authored under the email [email protected]. Could you amend the commit and either A) modify the signed-off-by OR B) modify your author email in the commit?

This will allow our CI pipeline to pass and we can merge the PR

I fixed the author of my commit message to match the sign-off.

[claucambra]

One last thing -- the sign-off points to [email protected] but it seems your commit is in fact authored under the email [email protected]. Could you amend the commit and either A) modify the signed-off-by OR B) modify your author email in the commit?
This will allow our CI pipeline to pass and we can merge the PR

I fixed the author of my commit message to match the sign-off.

Awesome, thanks!

[claucambra]

/backport to stable-3.10

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-6023-b1db1fb59999837227e5e64ce28d36fd2f4cf4dd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.