-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite share expiration date field's date handling, fixing issues #5961
Conversation
/backport to stable-3.9 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5961 +/- ##
==========================================
- Coverage 60.14% 60.11% -0.04%
==========================================
Files 145 145
Lines 18872 18872
==========================================
- Hits 11351 11344 -7
- Misses 7521 7528 +7 |
SonarCloud Quality Gate failed. 0 Bugs 0.0% Coverage The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
/backport to stable-3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need automated tests for DateFieldBackend
otherwise, it is complicated to predict the behavior
Added automated tests now |
f3ef369
to
c01b669
Compare
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…rsing two-digit year strings Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…ckend Signed-off-by: Claudio Cambra <[email protected]>
c01b669
to
774918c
Compare
AppImage file: nextcloud-PR-5961-774918c5d124f0fa6c6f3b3a3c26f4d9892cdb93-x86_64.AppImage |
SonarCloud Quality Gate failed. 0 Bugs 86.4% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
/backport to stable-3.10 |
The backport to stable-3.10 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable-3.10
git pull origin stable-3.10
# Create the new backport branch
git checkout -b fix/foo-stable-3.10
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-3.10 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Thank you so much, @claucambra and @mgallien! ❤️ |
Rather than deal with messy dates and times (and timezones) using JS dates in QML, this PR moves the inner workings of the date input field into a C++ class using QDates, fixing lots of issues on this front.
Fixes #5627
Fixes #5495