Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.8] Fix unrecoverable freezing when PutMultiFileJob is used with upload rate limits enabled #5694

Merged
merged 16 commits into from
May 16, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5680

@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.8.2 milestone May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #5694 (7bd9db2) into stable-3.8 (a121dbe) will increase coverage by 0.02%.
The diff coverage is 41.48%.

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.8    #5694      +/-   ##
==============================================
+ Coverage       59.27%   59.30%   +0.02%     
==============================================
  Files             143      143              
  Lines           18443    18452       +9     
==============================================
+ Hits            10933    10943      +10     
+ Misses           7510     7509       -1     
Impacted Files Coverage Δ
src/libsync/putmultifilejob.h 0.00% <ø> (-75.00%) ⬇️
src/libsync/bandwidthmanager.cpp 39.39% <3.33%> (+2.07%) ⬆️
src/libsync/configfile.cpp 26.01% <11.76%> (-0.49%) ⬇️
src/libsync/putmultifilejob.cpp 91.83% <84.61%> (-8.17%) ⬇️
src/libsync/bulkpropagatorjob.cpp 74.71% <93.75%> (+1.53%) ⬆️

... and 1 file with indirect coverage changes

claucambra added 11 commits May 16, 2023 11:20
…const auto, readability, etc

Signed-off-by: Claudio Cambra <[email protected]>
@mgallien mgallien force-pushed the backport/5680/stable-3.8 branch from 9ccc63a to 7bd9db2 Compare May 16, 2023 09:21
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

41.8% 41.8% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5694-7bd9db2cbd300a3d6d97e412c73ef18fdc1b265c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan camilasan merged commit 5a4c368 into stable-3.8 May 16, 2023
@camilasan camilasan deleted the backport/5680/stable-3.8 branch May 16, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants