Dismiss notifications #5687
Merged
Dismiss notifications #5687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilasan
force-pushed
the
bugfix/notifications
branch
from
fa333ef to
dcd7783
Compare
camilasan
force-pushed
the
bugfix/notifications
branch
from
dcd7783 to
3b9cc7c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5687 +/- ##
==========================================
- Coverage 59.28% 59.27% -0.01%
==========================================
Files 143 143
Lines 18463 18463
==========================================
- Hits 10945 10944 -1
- Misses 7518 7519 +1 |
camilasan
force-pushed
the
bugfix/notifications
branch
from
3b9cc7c to
dae575e
Compare
camilasan
force-pushed
the
bugfix/notifications
branch
from
dae575e to
3ab72ab
Compare
mgallien
requested changes
May 15, 2023
claucambra
approved these changes
May 16, 2023
camilasan
force-pushed
the
bugfix/notifications
branch
from
3ab72ab to
0931c1b
Compare
mgallien
approved these changes
May 16, 2023
- Fix for #5606 and #5585. - That is how it is done in the server and other clients. - Update tests. Signed-off-by: Camila <[email protected]>
mgallien
force-pushed
the
bugfix/notifications
branch
from
0931c1b to
d6db8fc
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
AppImage file: nextcloud-PR-5687-d6db8fcbd6247909feb3fb7508a56f5d2ce36562-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any notification missing a dismiss link will get one like in the server: