Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expire date field in Share settings #5659

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Fix expire date field in Share settings #5659

merged 5 commits into from
Jul 20, 2023

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented May 8, 2023 •
edited
Loading

This PR fix several bugs when it comes to properly resetting the expire date field after modification. It also better notifies users when the value they are providing is invalid due to, for instance, a limit of days on the expire date.

Screenshot 2023-05-08 at 20 08 45

@claucambra claucambra self-assigned this May 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra
Copy link
Collaborator Author

Closes #5627

@claucambra
Copy link
Collaborator Author

/backport to stable-3.9

@Spheron101 Spheron101 mentioned this pull request Jul 5, 2023
Closed
8 tasks
@tlueder
Copy link

tlueder commented Jul 8, 2023

Hi any updates on this patch?

@claucambra claucambra force-pushed the bugfix/expire-date-set-share-view branch from d6cdf71 to ef5ee5d Compare July 20, 2023 10:50
@claucambra claucambra requested a review from camilasan July 20, 2023 10:51
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #5659 (772db97) into master (759c2a2) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 772db97 differs from pull request most recent head d0e8e67. Consider uploading reports for the commit d0e8e67 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5659      +/-   ##
==========================================
- Coverage   60.08%   60.06%   -0.03%     
==========================================
  Files         145      145              
  Lines       18756    18756              
==========================================
- Hits        11270    11266       -4     
- Misses       7486     7490       +4

see 2 files with indirect coverage changes

@allexzander
Copy link
Contributor

@claucambra Please squash commits before merge

@claucambra claucambra force-pushed the bugfix/expire-date-set-share-view branch 2 times, most recently from 772db97 to 68bd1f7 Compare July 20, 2023 14:49
@claucambra
Rename "moreMenu" ColumnLayout to "scrollContentsColumn" in ShareView…
e84a5dc 
…, stop treating like menu which it used to be

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Make sure to imperatively set text for spinbox textfield after user b…
aaeaad9 
…reaks binding by editing

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Ensure the text for the expire date spin box is updated even in situa…
da7d8c1 
…tions when the expire date is forced back down to the same one being currently held

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add ability for NCInputTextField to display red border when invalid i…
00ec93f 
…nput provided

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Track invalid input in ShareDetailsPage expireDateSpinBoxTextField
d0e8e67 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra force-pushed the bugfix/expire-date-set-share-view branch from 68bd1f7 to d0e8e67 Compare July 20, 2023 15:17
@claucambra claucambra merged commit bb87813 into master Jul 20, 2023
@claucambra claucambra deleted the bugfix/expire-date-set-share-view branch July 20, 2023 15:21
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 20, 2023
Merged
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5659-d0e8e67c724709ba7202d3a730925caffac51c65-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@Spheron101
Copy link

3.9.4 still not working

@mgallien mgallien added this to the 3.10.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
7 participants
@claucambra @tlueder @allexzander @nextcloud-desktop-bot @Spheron101 @camilasan @mgallien