Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AccountPtr in Account signals instead of raw pointer #5543

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Use AccountPtr in Account signals instead of raw pointer #5543

wants to merge 6 commits into from

Conversation

claucambra
Copy link
Collaborator

No description provided.

@claucambra claucambra self-assigned this Mar 22, 2023
@claucambra claucambra force-pushed the bugfix/signal-account-ptr branch from 5f71219 to 5a3752d Compare March 22, 2023 14:32
@claucambra claucambra mentioned this pull request Mar 22, 2023
Merged
mgallien
mgallien requested changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestPushNotifications test is failing for me
can you investigate ?

@claucambra
Copy link
Collaborator Author

TestPushNotifications test is failing for me
can you investigate ?

Now fixed

@claucambra claucambra requested a review from mgallien March 23, 2023 16:48
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

26.1% 26.1% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #5543 (6146f02) into master (54a11e8) will decrease coverage by 0.08%.
The diff coverage is 14.28%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5543      +/-   ##
==========================================
- Coverage   58.96%   58.88%   -0.08%     
==========================================
  Files         143      143              
  Lines       18314    18332      +18     
==========================================
- Hits        10798    10795       -3     
- Misses       7516     7537      +21
Impacted Files Coverage Δ
src/libsync/account.h 36.84% <ø> (ø)
src/libsync/creds/httpcredentials.cpp 6.87% <0.00%> (-0.02%) ⬇️
src/libsync/account.cpp 35.85% <16.66%> (ø)

... and 5 files with indirect coverage changes

@claucambra claucambra added this to the 3.13.1 milestone Jun 9, 2024
@mgallien mgallien modified the milestones: 3.13.1, 3.13.2 Jul 2, 2024
@camilasan camilasan modified the milestones: 3.13.2, 3.13.3 Jul 9, 2024
@mgallien mgallien modified the milestones: 3.13.3, 3.14.0 Aug 23, 2024
@claucambra claucambra modified the milestones: 3.14.0, 3.14.2 Oct 11, 2024
@claucambra claucambra force-pushed the bugfix/signal-account-ptr branch 2 times, most recently from 86709cb to b88a6f5 Compare October 18, 2024 06:25
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.1% Coverage on New Code (required ≥ 80%)
61 New Code Smells (required ≤ 0)
D Maintainability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Rello Rello modified the milestones: 3.14.2, 3.14.3 Oct 18, 2024
@claucambra claucambra modified the milestones: 3.14.4, 3.14.5 Nov 3, 2024
@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
@claucambra claucambra force-pushed the bugfix/signal-account-ptr branch from b88a6f5 to 7bdd453 Compare November 20, 2024 07:13
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5543-7bdd45314d7c866bee49e0f5969afe926d7eb0d7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.1% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
76 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Rello Rello modified the milestones: 3.15.0, 3.16.0 Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

@mgallien mgallien Awaiting requested review from mgallien

Requested changes must be addressed to merge this pull request.

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@claucambra @nextcloud-desktop-bot @mgallien @camilasan @Rello