Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/disable talk chat notifications #5433

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Feature/disable talk chat notifications #5433

merged 6 commits into from
Nov 21, 2024

Conversation

claucambra
Copy link
Collaborator

Screenshot 2023-02-13 at 14 50 10

@claucambra claucambra self-assigned this Feb 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 13, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.93%. Comparing base (3dc583c) to head (b5a132c).
Report is 1080 commits behind head on master.

❗ Current head b5a132c differs from pull request most recent head cafe626

Please upload reports for the commit cafe626 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5433      +/-   ##
==========================================
- Coverage   60.79%   57.93%   -2.87%     
==========================================
  Files         145      141       -4     
  Lines       18836    18142     -694     
==========================================
- Hits        11451    10510     -941     
- Misses       7385     7632     +247
Files Coverage Δ
src/libsync/configfile.cpp 26.45% <0.00%> (-1.58%) ⬇️

... and 81 files with indirect coverage changes

@claucambra claucambra added this to the 3.13.1 milestone Jun 9, 2024
mgallien
mgallien requested changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you have a look at my comment, rebase and fix the conflict ?

src/libsync/configfile.h Outdated Show resolved Hide resolved
@claucambra claucambra force-pushed the feature/disable-talk-notifications branch from b5a132c to cafe626 Compare June 26, 2024 09:45
@claucambra claucambra requested a review from mgallien June 26, 2024 09:45
@claucambra
Copy link
Collaborator Author

Thanks for review @mgallien addressed comments

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
28 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien modified the milestones: 3.13.1, 3.13.2 Jul 2, 2024
@camilasan camilasan modified the milestones: 3.13.2, 3.13.3 Jul 9, 2024
@mgallien mgallien modified the milestones: 3.13.3, 3.14.0 Aug 23, 2024
@claucambra claucambra modified the milestones: 3.14.0, 3.15.0 Oct 11, 2024
mgallien
mgallien requested changes Nov 14, 2024
View reviewed changes
src/gui/tray/usermodel.cpp Outdated Show resolved Hide resolved
@claucambra claucambra requested a review from mgallien November 18, 2024 08:20
@claucambra claucambra force-pushed the feature/disable-talk-notifications branch 2 times, most recently from 83f9d07 to f352123 Compare November 21, 2024 02:17
@claucambra @mgallien
Remove unneeded check for DnD status when showing desktop talk notifi…
e66135a 
…cation

The server will not deliver it anyway

Signed-off-by: Claudio Cambra <[email protected]>
@mgallien mgallien force-pushed the feature/disable-talk-notifications branch from f352123 to e66135a Compare November 21, 2024 11:31
@mgallien mgallien merged commit 52f066d into master Nov 21, 2024
9 of 14 checks passed
@mgallien mgallien deleted the feature/disable-talk-notifications branch November 21, 2024 11:31
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5433-e66135a59aff90a42c2ea8906edf16fd6609f60d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@claucambra @nextcloud-desktop-bot @mgallien @camilasan