Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/files lock #4420

Merged
merged 8 commits into from
May 2, 2022
Merged

Feature/files lock #4420

merged 8 commits into from
May 2, 2022

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Apr 7, 2022

close #4382

@mgallien mgallien force-pushed the feature/files_lock branch from e223ee1 to 76044d5 Compare April 7, 2022 08:48
@mgallien mgallien force-pushed the feature/files_lock branch 4 times, most recently from c43f8d4 to ee0bb4a Compare April 13, 2022 08:05
@mgallien
Copy link
Collaborator Author

contextual menu when a file is locked by an user

image

@mgallien mgallien force-pushed the feature/files_lock branch 10 times, most recently from 849a4bd to fe95078 Compare April 20, 2022 14:52
@mgallien mgallien force-pushed the feature/files_lock branch 8 times, most recently from 673c311 to 9f53c5e Compare April 20, 2022 19:41
@mgallien mgallien force-pushed the feature/files_lock branch 4 times, most recently from a504f99 to 28ce984 Compare April 26, 2022 22:25
@mgallien mgallien marked this pull request as ready for review April 27, 2022 07:21
@mgallien mgallien force-pushed the feature/files_lock branch 2 times, most recently from 7c0ab3d to b2e59eb Compare April 27, 2022 14:59
@mgallien mgallien requested a review from allexzander April 27, 2022 15:00
@mgallien
Copy link
Collaborator Author

mgallien commented Apr 27, 2022

screenshot of share dialog with lock information
image
the contextual menu of the same file
image

@mgallien mgallien force-pushed the feature/files_lock branch from b2e59eb to d7fcd70 Compare April 28, 2022 08:18
@mgallien mgallien force-pushed the feature/files_lock branch 3 times, most recently from 564c188 to 0615344 Compare May 1, 2022 08:26
mgallien added 8 commits May 2, 2022 13:52
reduce the measure of branching complexity by reformatting the method

Signed-off-by: Matthieu Gallien <[email protected]>
fetch lock properties from server

decode them and store them in sync database

test to ensure we do properly handle those properties

Signed-off-by: Matthieu Gallien <[email protected]>
add new commands to the contextual menu provided by our files explorer
plugins to allow locking/unlocking a file

Signed-off-by: Matthieu Gallien <[email protected]>
use a native dialog to show users errors when trying to lock/unlock
files

Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the feature/files_lock branch from 0615344 to 702e9ab Compare May 2, 2022 11:52
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4420-702e9abe4b9110103557b06587836cbaa4609c75-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
1.9% 1.9% Duplication

@mgallien mgallien merged commit eeb0d20 into master May 2, 2022
@mgallien mgallien deleted the feature/files_lock branch May 2, 2022 12:50
@mgallien mgallien added this to the 3.5.0 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement file locking
4 participants