Write logs to local, not config dir

[franga2000]

As discussed in #3406

Tested:

• Platforms:
  • Linux
  • Windows
  • Mac OS
• Features:
  • Dir structure and files created and written to as normal
  • Old logs are gzipped correctly
  • Creating a debug archive still includes log files

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-3868-a09a4bf3333e6c29b52ff824b3b51f2ad34813fe-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[FlexW]

Cool, thank you :) will you be able to test it on Windows and macOS aswell?

[franga2000]

Yes, but I'm still setting up toolchains on both. Should have results in a few hrs

EDIT: yeah, that was optimistic, some things came up... 😅

[FlexW]

OK, I marked it as a draft pr. Feel free to request a review from me, @mgallien, @allexzander and @camilasan if it's ready, and mark it then as ready for review.

[allexzander]

@franga2000 I'd say, you need to change the corresponding part in QString ConfigFile::configPath() const if you want to only affect Linux. There is certain logic in QString ConfigFile::configPath() const that gets executed for Windows. Better try not to change the behavior.

[franga2000]

Affecting other platforms was intentional, as discussed here: #3406 (comment).

As far as I can tell, configPath() only handles Windows differently because QStandardPaths::AppConfigLocation somewhat strangely resolves to AppData\Local. But AppLocalDataLocation resolves "reasonably" on Windows (according to the conventions I know). The rest of the login in the function moves config files from a legacy location, which doesn't interfere with this change either.

Given that, do you still prefer I leave Windows as it was before (logs alongside configs in AppData\Roaming)?

[franga2000]

I haven't been able to build this to test on Windows or macOS as I only have VMs of them and everything takes ages to install. Any chance someone with a working build environment could give this a quick test (or at least compile and send it to me)?

[Rello]

Hello,

Thank you for your contribution to the Desktop Client with this pull request.
We are closing this request as it is outdated, no longer relevant (e.g., due to Qt 6), or does not align with the current roadmap.

We truly value your support and hope to see more contributions from you in the future!

Best regards,
Nextcloud Desktop Team