Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in the doc, gets substitution variables from cmake instead of hard coded value #3210

Closed
wants to merge 4 commits into from

Conversation

mgallien
Copy link
Collaborator

Signed-off-by: Matthieu Gallien [email protected]

@mgallien mgallien changed the title in the doc, gets substitution variables from cmake instaed of hard coded value in the doc, gets substitution variables from cmake instead of hard coded value Apr 26, 2021
@mgallien
Copy link
Collaborator Author

Build is currently broken because CI does not use cmake but directly plain old make.

@mgallien
Copy link
Collaborator Author

mgallien commented May 7, 2021

/rebase

@mgallien mgallien marked this pull request as ready for review August 25, 2021 16:10
@mgallien
Copy link
Collaborator Author

Need some changes to the daily build that is generating the documentation
please review but do not merge until that is done

@mgallien mgallien removed the request for review from er-vin August 25, 2021 16:13
cmake build of documentation is not adding the same options that plain
old makefile

fix incoherency

Signed-off-by: Matthieu Gallien <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3210-2ecbdb62e3a456715e39df3335006561f0e34e79-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
Copy link
Collaborator Author

we do not want to keep this one

@mgallien mgallien closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants