avoid for loops detaching the container when uneeded

Signed-off-by: Matthieu Gallien <[email protected]>
nextcloud · Oct 11, 2023 · fdb20b6 · fdb20b6
1 parent 092cb4b
commit fdb20b6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/libsync/syncengine.cpp b/src/libsync/syncengine.cpp
@@ -811,7 +811,7 @@ void SyncEngine::slotDiscoveryFinished()
         }
 
         if (_discoveryPhase->_hasDownloadRemovedItems && _discoveryPhase->_hasUploadErrorItems) {
-            for (const auto &item : _syncItems) {
+            for (const auto &item : qAsConst(_syncItems)) {
                 if (item->_instruction == CSYNC_INSTRUCTION_ERROR && item->_direction == SyncFileItem::Up) {
                     item->_instruction = CSYNC_INSTRUCTION_IGNORE;
                 }

diff --git a/test/testsecurefiledrop.cpp b/test/testsecurefiledrop.cpp
@@ -142,7 +142,8 @@ private slots:
 
             bool isAnyFileDropFileMissing = false;
 
-            for (const auto &key : metadata->fileDrop().keys()) {
+            const auto allKeys = metadata->fileDrop().keys();
+            for (const auto &key : allKeys) {
                 if (std::find_if(metadata->files().constBegin(), metadata->files().constEnd(), [&key](const EncryptedFile &encryptedFile) {
                     return encryptedFile.encryptedFilename == key;
                 }) == metadata->files().constEnd()) {