only use VFS update instruction when sync engine would do nothing

will ensure we do not erroneously use this instruction when we should not Signed-off-by: Matthieu Gallien <[email protected]>
nextcloud · Jun 20, 2024 · f915d2a · f915d2a
1 parent 29df094
commit f915d2a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/libsync/discovery.cpp b/src/libsync/discovery.cpp
@@ -1681,8 +1681,9 @@ void ProcessDirectoryJob::processFileFinalize(
     }
 
     if (_discoveryData->_syncOptions._vfs &&
-        item->_type == CSyncEnums::ItemTypeFile &&
-        !_discoveryData->_syncOptions._vfs->isPlaceHolderInSync(_discoveryData->_localDir + path._local)) {
+            (item->_type == CSyncEnums::ItemTypeFile || item->_type == CSyncEnums::ItemTypeDirectory) &&
+            item->_instruction == CSyncEnums::CSYNC_INSTRUCTION_NONE &&
+            !_discoveryData->_syncOptions._vfs->isPlaceHolderInSync(_discoveryData->_localDir + path._local)) {
         item->_instruction = CSyncEnums::CSYNC_INSTRUCTION_UPDATE_VFS_METADATA;
     }