Skip to content

Commit

Permalink
List sync folders in the file explorer with user's username.
Browse files Browse the repository at this point in the history 
Signed-off-by: Camila Ayres <[email protected]>
  • Loading branch information
@camilasan @backportbot
camilasan authored and backportbot[bot] committed Aug 6, 2024
1 parent 973dbba commit dbad78c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/gui/navigationpanehelper.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,9 @@ void NavigationPaneHelper::updateCloudStorageRegistry()

QString title = folder->shortGuiRemotePathOrAppName();
// Write the account name in the sidebar only when using more than one account.
if (AccountManager::instance()->accounts().size() > 1)
title = title % " - " % folder->accountState()->account()->displayName();
if (AccountManager::instance()->accounts().size() > 1) {
title = title % " - " % folder->accountState()->account()->prettyName();
}
QString iconPath = QDir::toNativeSeparators(qApp->applicationFilePath());
QString targetFolderPath = QDir::toNativeSeparators(folder->cleanPath());

Expand Down

3 comments on commit dbad78c

@SnejPro
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible issue due to this commit: #7049

@AndreGeddert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilasan this change seems not usefull for most use cases. I think the use case where a user with the same name has several accounts on different instances is more common than the case where a user has several accounts on the same instance with different usernames. For example i have accounts with the exact same username and full name on my private nextcloud, my employers nextcloud, my clients nextcloud etc. and all of these are now labled exactly the same in explorer.

@SnejPro
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilasan Would it be an option to revert these changes until there's a option to customize this setting in the gui?

Please sign in to comment.