Ensure we are checking for tags in correct server path regardless of …

…the particular local path Fixes issues with users who are using remote non-root sync folders Signed-off-by: Claudio Cambra <[email protected]>
nextcloud · Oct 21, 2024 · 9c5d1e2 · 9c5d1e2
1 parent 6574625
commit 9c5d1e2
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/src/gui/filedetails/filedetails.cpp b/src/gui/filedetails/filedetails.cpp
@@ -170,11 +170,7 @@ FileTagModel *FileDetails::fileTagModel() const
 
 void FileDetails::updateFileTagModel(const AccountPtr &account)
 {
-    Q_ASSERT(account);
-
-    const auto serverRelPath = QString(folder->remotePathTrailingSlash() + name());
-
-    _fileTagModel = std::make_unique<FileTagModel>(serverRelPath, account);
+    _fileTagModel = std::make_unique<FileTagModel>(_fileRecord, _folder, account);
     Q_EMIT fileTagModelChanged();
 }
 

diff --git a/src/gui/filetagmodel.cpp b/src/gui/filetagmodel.cpp
@@ -20,13 +20,21 @@ Q_LOGGING_CATEGORY(lcFileTagModel, "nextcloud.gui.filetagmodel", QtInfoMsg)
 
 namespace OCC {
 
-FileTagModel::FileTagModel(const QString &serverRelativePath,
+FileTagModel::FileTagModel(const SyncJournalFileRecord &fileRecord,
+                           const Folder * const syncFolder,
                            const AccountPtr &account,
                            QObject * const parent)
     : QAbstractListModel(parent)
-    , _serverRelativePath(serverRelativePath)
     , _account(account)
 {
+    _serverRelativePath = syncFolder->remotePathTrailingSlash() + fileRecord.path();
+
+    if (const auto vfsMode = syncFolder->vfs().mode(); fileRecord.isVirtualFile() && vfsMode == Vfs::WithSuffix) {
+        if (const auto suffix = syncFolder->vfs().fileSuffix(); !suffix.isEmpty() && _serverRelativePath.endsWith(suffix)) {
+            _serverRelativePath.chop(suffix.length());
+        }
+    }
+
     fetchFileTags();
 }
 

diff --git a/src/gui/filetagmodel.h b/src/gui/filetagmodel.h
@@ -16,6 +16,8 @@
 
 #include <QAbstractListModel>
 
+#include "common/syncjournalfilerecord.h"
+#include "gui/folder.h"
 #include "libsync/account.h"
 
 namespace OCC {
@@ -31,7 +33,10 @@ class FileTagModel : public QAbstractListModel
     Q_PROPERTY(QString overflowTagsString READ overflowTagsString NOTIFY overflowTagsStringChanged)
 
 public:
-    explicit FileTagModel(const QString &serverRelativePath, const AccountPtr &account, QObject * const parent = nullptr);
+    explicit FileTagModel(const SyncJournalFileRecord &fileRecord,
+                          const Folder *const syncFolder,
+                          const AccountPtr &account,
+                          QObject *const parent = nullptr);
 
     [[nodiscard]] int rowCount(const QModelIndex &parent = QModelIndex()) const override;
     [[nodiscard]] QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;