Lazily load settings view widget

Signed-off-by: Claudio Cambra <[email protected]>
nextcloud · Sep 4, 2023 · 62e85b3 · 62e85b3
1 parent f2bebce
commit 62e85b3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/gui/macOS/ui/fileprovidersettingscontroller.h b/src/gui/macOS/ui/fileprovidersettingscontroller.h
@@ -32,6 +32,8 @@ class FileProviderSettingsController : public QObject
     [[nodiscard]] QQuickWidget *settingsViewWidget();
 
 private:
+    void instantiateSettingsWidget();
+
     class MacImplementation;
     std::unique_ptr<MacImplementation> d;
 

diff --git a/src/gui/macOS/ui/fileprovidersettingscontroller_mac.mm b/src/gui/macOS/ui/fileprovidersettingscontroller_mac.mm
@@ -60,7 +60,10 @@
     : QObject{parent}
 {
     d = std::make_unique<FileProviderSettingsController::MacImplementation>(this);
+}
 
+void FileProviderSettingsController::instantiateSettingsWidget()
+{
     _settingsViewWidget = std::make_unique<QQuickWidget>(Systray::instance()->trayEngine(), nullptr);
     _settingsViewWidget->setResizeMode(QQuickWidget::SizeRootObjectToView);
     _settingsViewWidget->setSource(QUrl(fpSettingsQmlPath));
@@ -69,6 +72,10 @@
 
 QQuickWidget *FileProviderSettingsController::settingsViewWidget()
 {
+    if (!_settingsViewWidget) {
+        instantiateSettingsWidget();
+    }
+
     return _settingsViewWidget.get();
 }