Skip to content

Commit

Permalink
fix: wrap up after debugging this
Browse files Browse the repository at this point in the history
Signed-off-by: Josh <[email protected]>
  • Loading branch information
joshtrichards authored and claucambra committed Jul 21, 2024
1 parent 4affce1 commit 5c3c6a8
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/clang-tidy-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,10 @@ jobs:
mkdir clang-tidy-result
- name: Analyze
run: |
pwd && ls -alt
/usr/bin/git config --global --add safe.directory "$GITHUB_WORKSPACE"
/usr/bin/git diff -U0 HEAD^ | clang-tidy-diff-15.py -checks='-*,modernize-use-auto,modernize-use-using,modernize-use-nodiscard,modernize-use-nullptr,modernize-use-override,cppcoreguidelines-pro-type-static-cast-downcast' -p1 -path build -export-fixes clang-tidy-result/fixes.yml
- name: Run clang-tidy-pr-comments action
uses: platisd/[email protected] # >1.4.3 switches to compose and runs into below mentioned issue w/o great workarounds (needs to be fixed by them not us)
#env:
#LD_LIBRARY_PATH: /__w/_tool/Python/ # workaround for https://github.com/actions/setup-python/issues/871 ever since clang-tidy-pr-comments became composite w/ embedded python version req
uses: platisd/[email protected] # >1.4.3 switches to composite method w/ a forced python version and breaks things: https://github.com/actions/setup-python/issues/871
with:
# The GitHub token (or a personal access token)
github_token: ${{ secrets.GITHUB_TOKEN }}
Expand Down

0 comments on commit 5c3c6a8

Please sign in to comment.