Skip to content

Commit

Permalink
Remove ssl options to re-use encryption session for different TCP con…
Browse files Browse the repository at this point in the history
…nections.

One option is said to be possibly breaking some sites: QSsl::SslOptionDisableSessionTickets
It disables the SSL session ticket extension and some servers are not compatible with the extension.

Signed-off-by: Camila Ayres <[email protected]>
  • Loading branch information
camilasan committed May 29, 2024
1 parent 1f3ca27 commit 5299677
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/libsync/account.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -483,11 +483,6 @@ QSslConfiguration Account::getOrCreateSslConfig()
// "An internal error number 1060 happened. SSL handshake failed, client certificate was requested: SSL error: sslv3 alert handshake failure"
QSslConfiguration sslConfig = QSslConfiguration::defaultConfiguration();

// Try hard to reuse session for different requests
sslConfig.setSslOption(QSsl::SslOptionDisableSessionTickets, false);
sslConfig.setSslOption(QSsl::SslOptionDisableSessionSharing, false);
sslConfig.setSslOption(QSsl::SslOptionDisableSessionPersistence, false);

sslConfig.setOcspStaplingEnabled(Theme::instance()->enableStaplingOCSP());

return sslConfig;
Expand Down

0 comments on commit 5299677

Please sign in to comment.