Skip to content

Commit

Permalink
fix: bump back to 1.4.3 clang-tidy-pr-comments to avoid workarounds
Browse files Browse the repository at this point in the history
Signed-off-by: Josh <[email protected]>
  • Loading branch information
joshtrichards authored Jun 29, 2024
1 parent d196903 commit 4ef0873
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/clang-tidy-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ jobs:
/usr/bin/git config --global --add safe.directory "$GITHUB_WORKSPACE"
/usr/bin/git diff -U0 HEAD^ | clang-tidy-diff-15.py -checks='-*,modernize-use-auto,modernize-use-using,modernize-use-nodiscard,modernize-use-nullptr,modernize-use-override,cppcoreguidelines-pro-type-static-cast-downcast' -p1 -path build -export-fixes clang-tidy-result/fixes.yml
- name: Run clang-tidy-pr-comments action
uses: platisd/clang-tidy-pr-comments@master
env:
LD_LIBRARY_PATH: ${{ github.workspace }}/Python/ # workaround for https://github.com/actions/setup-python/issues/871 ever since clang-tidy-pr-comments became composite w/ embedded python version req
uses: platisd/clang-tidy-pr-comments@v1.4.3 # >1.4.3 switches to compose and runs into below mentioned issue w/o great workarounds (needs to be fixed by them not us)
#env:
#LD_LIBRARY_PATH: /__w/_tool/Python/ # workaround for https://github.com/actions/setup-python/issues/871 ever since clang-tidy-pr-comments became composite w/ embedded python version req
with:
# The GitHub token (or a personal access token)
github_token: ${{ secrets.GITHUB_TOKEN }}
Expand Down

0 comments on commit 4ef0873

Please sign in to comment.