Merge pull request #6751 from nextcloud/bugfix/fixWrongMemoryAccessIn…

…ExcludeFiles avoid accessing a temp QString via QStringView after it is deleted
nextcloud · May 15, 2024 · 1b9fbb0 · 1b9fbb0
2 parents 62661b7 + ba00c50
commit 1b9fbb0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/csync/csync_exclude.cpp b/src/csync/csync_exclude.cpp
@@ -134,9 +134,9 @@ static CSYNC_EXCLUDE_TYPE _csync_excluded_common(const QString &path, bool exclu
 {
     /* split up the path */
     QStringView bname(path);
-    int lastSlash = path.lastIndexOf(QLatin1Char('/'));
+    int lastSlash = bname.lastIndexOf(QLatin1Char('/'));
     if (lastSlash >= 0) {
-        bname = path.mid(lastSlash + 1);
+        bname = bname.mid(lastSlash + 1);
     }
 
     qsizetype blen = bname.size();