Do not fail e2ee metadata parsing when current user is not present in…

… filedrop.

Signed-off-by: alex-z <[email protected]>

src/libsync/foldermetadata.cpp

@@ -769,8 +769,6 @@ bool FolderMetadata::parseFileDropPart(const QJsonDocument &doc)
     const auto fileDropObject = doc.object().value(filedropKey).toObject();
     const auto fileDropMap = fileDropObject.toVariantMap();
 
-    auto isFileDropAccessGranted = false;
-
     for (auto it = std::cbegin(fileDropMap); it != std::cend(fileDropMap); ++it) {
         const auto fileDropEntryParsed = it.value().toMap();
         FileDropEntry fileDropEntry{it.key(),
@@ -792,19 +790,17 @@ bool FolderMetadata::parseFileDropPart(const QJsonDocument &doc)
                     return false;
                 }
                 fileDropEntry.currentUser = fileDropEntryUser;
-                isFileDropAccessGranted = true;
+                break;
             }
         }
         if (!fileDropEntry.isValid()) {
             qCDebug(lcCseMetadata()) << "Could not parse filedrop data. fileDropEntry is invalid for userId" << fileDropEntry.currentUser.userId;
             _account->reportClientStatus(OCC::ClientStatusReportingStatus::E2EeError_GeneralError);
             return false;
         }
-        _fileDropEntries.push_back(fileDropEntry);
-    }
-
-    if (!isFileDropAccessGranted) {
-        _fileDropEntries.clear();
+        if (fileDropEntry.currentUser.isValid()) {
+            _fileDropEntries.push_back(fileDropEntry);
+        }
     }
     return true;
 }

src/libsync/foldermetadata.h

@@ -74,7 +74,7 @@ class OWNCLOUDSYNC_EXPORT FolderMetadata : public QObject
 
         inline bool isValid() const
         {
-            return !cipherText.isEmpty() && !nonce.isEmpty() && !authenticationTag.isEmpty() && currentUser.isValid();
+            return !cipherText.isEmpty() && !nonce.isEmpty() && !authenticationTag.isEmpty();
         }
     };