Clang Format Checker

Feature/e2ee use hardware token secure storage #3232

Summary
Jobs
- build
Run details
- Usage
- Workflow file

Triggered via pull request March 29, 2024 15:18

mgallien

synchronize #5877

feature/e2eeUseHardwareTokenSecureStorage

Status Success

Total duration 1m 13s

Artifacts –

clang-format.yml

on: pull_request

build

1m 3s

Annotations

10 errors, 10 warnings, and 10 notices

src/common/syncjournaldb.cpp:19:10 [clang-diagnostic-error]: src/common/syncjournaldb.cpp#L19

'QCryptographicHash' file not found

src/common/syncjournalfilerecord.h:22:10 [clang-diagnostic-error]: src/common/syncjournalfilerecord.h#L22

'QString' file not found

src/gui/accountsettings.h:18:10 [clang-diagnostic-error]: src/gui/accountsettings.h#L18

'QWidget' file not found

src/gui/connectionvalidator.cpp:15:10 [clang-diagnostic-error]: src/gui/connectionvalidator.cpp#L15

'QJsonDocument' file not found

src/gui/folder.cpp:16:10 [clang-diagnostic-error]: src/gui/folder.cpp#L16

'common/syncjournaldb.h' file not found

src/gui/tray/activitydata.h:18:10 [clang-diagnostic-error]: src/gui/tray/activitydata.h#L18

'syncfileitem.h' file not found

src/gui/tray/activitylistmodel.h:18:10 [clang-diagnostic-error]: src/gui/tray/activitylistmodel.h#L18

'QtCore' file not found

src/libsync/account.h:19:10 [clang-diagnostic-error]: src/libsync/account.h#L19

'QByteArray' file not found

src/libsync/clientsideencryptionprimitives.h:17:10 [clang-diagnostic-error]: src/libsync/clientsideencryptionprimitives.h#L17

'QtCore/qglobal.h' file not found

src/libsync/discoveryphase.h:17:10 [clang-diagnostic-error]: src/libsync/discoveryphase.h#L17

'QObject' file not found

src/gui/accountsettings.cpp:334:16 [cppcoreguidelines-init-variables]: src/gui/accountsettings.cpp#L334

variable '_accountState' is not initialized

src/gui/accountsettings.cpp:1140:43 [bugprone-easily-swappable-parameters]: src/gui/accountsettings.cpp#L1140

2 adjacent parameters of 'showConnectionLabel' of similar type are easily swapped by mistake

src/gui/accountsettings.cpp:1517:23 [readability-convert-member-functions-to-static]: src/gui/accountsettings.cpp#L1517

method 'slotE2eEncryptionCertificateNeedMigration' can be made static

src/gui/accountsettings.cpp:1525:23 [readability-convert-member-functions-to-static]: src/gui/accountsettings.cpp#L1525

method 'updateBlackListAndScheduleFolderSync' can be made static

src/gui/systray.cpp:326:15 [readability-convert-member-functions-to-static]: src/gui/systray.cpp#L326

method 'createEncryptionTokenDiscoveryDialog' can be made static

src/gui/systray.cpp:344:15 [readability-convert-member-functions-to-static]: src/gui/systray.cpp#L344

method 'destroyEncryptionTokenDiscoveryDialog' can be made static

src/gui/systray.cpp:354:15 [modernize-use-trailing-return-type]: src/gui/systray.cpp#L354

use a trailing return type for this function

src/libsync/clientsideencryptionprimitives.h:22:11 [cppcoreguidelines-avoid-non-const-global-variables]: src/libsync/clientsideencryptionprimitives.h#L22

variable 'OCC' is non-const and globally accessible, consider making it const

src/libsync/discoveryphase.cpp:462:41 [modernize-use-trailing-return-type]: src/libsync/discoveryphase.cpp#L462

use a trailing return type for this function

src/libsync/discoveryphase.cpp:467:37 [bugprone-easily-swappable-parameters]: src/libsync/discoveryphase.cpp#L467

2 adjacent parameters of 'propertyMapToRemoteInfo' of similar type are easily swapped by mistake

Run clang-format on src/common/syncjournaldb.cpp: src/common/syncjournaldb.cpp#L1

File src/common/syncjournaldb.cpp does not conform to Custom style guidelines. (lines 51, 989, 991)

Run clang-format on src/csync/csync.h: src/csync/csync.h#L1

File src/csync/csync.h does not conform to Custom style guidelines. (lines 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 153, 155)

Run clang-format on src/gui/accountsettings.cpp: src/gui/accountsettings.cpp#L1

File src/gui/accountsettings.cpp does not conform to Custom style guidelines. (lines 287, 288, 289, 290)

Run clang-format on src/gui/accountsettings.h: src/gui/accountsettings.h#L1

File src/gui/accountsettings.h does not conform to Custom style guidelines. (lines 65)

Run clang-format on src/gui/folder.cpp: src/gui/folder.cpp#L1

File src/gui/folder.cpp does not conform to Custom style guidelines. (lines 132)

Run clang-format on src/gui/owncloudgui.cpp: src/gui/owncloudgui.cpp#L1

File src/gui/owncloudgui.cpp does not conform to Custom style guidelines. (lines 139, 584)

Run clang-format on src/gui/settingsdialog.cpp: src/gui/settingsdialog.cpp#L1

File src/gui/settingsdialog.cpp does not conform to Custom style guidelines. (lines 213)

Run clang-format on src/gui/systray.cpp: src/gui/systray.cpp#L1

File src/gui/systray.cpp does not conform to Custom style guidelines. (lines 334)

Run clang-format on src/gui/systray.h: src/gui/systray.h#L1

File src/gui/systray.h does not conform to Custom style guidelines. (lines 21, 198)

Run clang-format on src/gui/tray/activitylistmodel.cpp: src/gui/tray/activitylistmodel.cpp#L1

File src/gui/tray/activitylistmodel.cpp does not conform to Custom style guidelines. (lines 44, 53, 234, 376, 683, 684, 685, 686)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/e2ee use hardware token secure storage #3232

Summary