Clang Format Checker

Fix macOS legacy build breakage caused by std::filesystem #3231

Sign in to view logs

Summary
Jobs
- build
Run details
- Usage
- Workflow file

Triggered via pull request March 28, 2024 11:11

claucambra

synchronize #6583

bugfix/macoslegacy-build-fix-stdfilesystem

Status Success

Total duration 11m 55s

Artifacts –

clang-format.yml

on: pull_request

Annotations

3 errors, 4 warnings, and 1 notice

src/libsync/filesystem.h:17:10 [clang-diagnostic-error]: src/libsync/filesystem.h#L17

'config.h' file not found

src/libsync/propagatedownload.cpp:15:10 [clang-diagnostic-error]: src/libsync/propagatedownload.cpp#L15

'config.h' file not found

src/libsync/propagatedownload.h:16:10 [clang-diagnostic-error]: src/libsync/propagatedownload.h#L16

'owncloudlib.h' file not found

src/libsync/filesystem.cpp:198:18 [modernize-use-trailing-return-type]: src/libsync/filesystem.cpp#L198

use a trailing return type for this function

src/libsync/filesystem.cpp:198:39 [bugprone-easily-swappable-parameters]: src/libsync/filesystem.cpp#L198

2 adjacent parameters of 'setFolderPermissions' of similar type are easily swapped by mistake

src/libsync/filesystem.cpp:334:2 [readability-redundant-preprocessor]: src/libsync/filesystem.cpp#L334

nested redundant #if; consider removing it

src/libsync/propagatedownload.cpp:1169:29 [readability-function-cognitive-complexity]: src/libsync/propagatedownload.cpp#L1169

function 'downloadFinished' has cognitive complexity of 54 (threshold 25)

Run clang-format on src/libsync/filesystem.h: src/libsync/filesystem.h#L1

File src/libsync/filesystem.h does not conform to Custom style guidelines. (lines 108)