Skip to content
Clang Format Checker

if desktop client sent a first reply: wait for the menu data #3183

Sign in to view logs

if desktop client sent a first reply: wait for the menu data

if desktop client sent a first reply: wait for the menu data #3183

Triggered via pull request March 19, 2024 17:15
@mgallienmgallien
synchronize #6553
bugfix/preventMissingContextMenuOnWindowsFileExplorer
Status Success
Total duration 4m 45s
Artifacts –

clang-format.yml

on: pull_request
build
39s
build
Fit to window
Zoom out
Zoom in

Annotations

5 errors, 10 warnings, and 5 notices
shell_integration/windows/NCContextMenu/NCClientInterface.cpp:17:10 [clang-diagnostic-error]: shell_integration/windows/NCContextMenu/NCClientInterface.cpp#L17
'CommunicationSocket.h' file not found
shell_integration/windows/NCContextMenu/NCClientInterface.h:32:10 [clang-diagnostic-error]: shell_integration/windows/NCContextMenu/NCClientInterface.h#L32
'string' file not found
shell_integration/windows/NCOverlays/NCOverlay.h:20:10 [clang-diagnostic-error]: shell_integration/windows/NCOverlays/NCOverlay.h#L20
'shlobj.h' file not found
shell_integration/windows/NCUtil/CommunicationSocket.h:22:10 [clang-diagnostic-error]: shell_integration/windows/NCUtil/CommunicationSocket.h#L22
'string' file not found
shell_integration/windows/NCUtil/RemotePathChecker.h:17:10 [clang-diagnostic-error]: shell_integration/windows/NCUtil/RemotePathChecker.h#L17
'string' file not found
shell_integration/windows/NCContextMenu/NCClientInterface.cpp:36:55 [modernize-use-trailing-return-type]: shell_integration/windows/NCContextMenu/NCClientInterface.cpp#L36
use a trailing return type for this function
shell_integration/windows/NCContextMenu/NCClientInterface.cpp:36:55 [readability-function-cognitive-complexity]: shell_integration/windows/NCContextMenu/NCClientInterface.cpp#L36
function 'FetchInfo' has cognitive complexity of 29 (threshold 25)
shell_integration/windows/NCContextMenu/NCClientInterface.cpp:58:54 [cppcoreguidelines-init-variables]: shell_integration/windows/NCContextMenu/NCClientInterface.cpp#L58
variable 'converter' is not initialized
shell_integration/windows/NCContextMenu/NCClientInterface.cpp:70:17 [readability-isolate-declaration]: shell_integration/windows/NCContextMenu/NCClientInterface.cpp#L70
multiple declarations in a single statement reduces readability
shell_integration/windows/NCContextMenu/NCClientInterface.cpp:77:17 [readability-isolate-declaration]: shell_integration/windows/NCContextMenu/NCClientInterface.cpp#L77
multiple declarations in a single statement reduces readability
shell_integration/windows/NCContextMenu/NCContextMenu.cpp:27:13 [cppcoreguidelines-avoid-non-const-global-variables]: shell_integration/windows/NCContextMenu/NCContextMenu.cpp#L27
variable 'g_cDllRef' is non-const and globally accessible, consider making it const
shell_integration/windows/NCOverlays/NCOverlay.cpp:38:20 [modernize-use-trailing-return-type]: shell_integration/windows/NCOverlays/NCOverlay.cpp#L38
use a trailing return type for this function
shell_integration/windows/NCOverlays/NCOverlay.cpp:50:1 [cppcoreguidelines-pro-type-member-init]: shell_integration/windows/NCOverlays/NCOverlay.cpp#L50
constructor does not initialize these fields: ULONG, m_logger
shell_integration/windows/NCUtil/RemotePathChecker.cpp:33:25 [readability-function-cognitive-complexity]: shell_integration/windows/NCUtil/RemotePathChecker.cpp#L33
function 'workerThreadLoop' has cognitive complexity of 42 (threshold 25)
shell_integration/windows/NCUtil/RemotePathChecker.cpp:165:1 [cppcoreguidelines-pro-type-member-init]: shell_integration/windows/NCUtil/RemotePathChecker.cpp#L165
constructor does not initialize these fields: _pending, _cache, _watchedDirectories, _newQueries
Run clang-format on shell_integration/windows/NCContextMenu/NCContextMenu.cpp: shell_integration/windows/NCContextMenu/NCContextMenu.cpp#L1
File shell_integration/windows/NCContextMenu/NCContextMenu.cpp does not conform to Custom style guidelines. (lines 24, 151, 155, 169)
Run clang-format on shell_integration/windows/NCOverlays/NCOverlay.cpp: shell_integration/windows/NCOverlays/NCOverlay.cpp#L1
File shell_integration/windows/NCOverlays/NCOverlay.cpp does not conform to Custom style guidelines. (lines 44, 125)
Run clang-format on shell_integration/windows/NCUtil/CommunicationSocket.cpp: shell_integration/windows/NCUtil/CommunicationSocket.cpp#L1
File shell_integration/windows/NCUtil/CommunicationSocket.cpp does not conform to Custom style guidelines. (lines 84)
Run clang-format on shell_integration/windows/NCUtil/CommunicationSocket.h: shell_integration/windows/NCUtil/CommunicationSocket.h#L1
File shell_integration/windows/NCUtil/CommunicationSocket.h does not conform to Custom style guidelines. (lines 38)
Run clang-format on shell_integration/windows/NCUtil/RemotePathChecker.cpp: shell_integration/windows/NCUtil/RemotePathChecker.cpp#L1
File shell_integration/windows/NCUtil/RemotePathChecker.cpp does not conform to Custom style guidelines. (lines 170)