Skip to content
Clang Format Checker

Allow installation to close shell extension DLLs via the custom action. Disable reboot prompt in case of the version with this change was previously already installed. #3178

Sign in to view logs

Allow installation to close shell extension DLLs via the custom action. Disable reboot prompt in case of the version with this change was previously already installed.

Allow installation to close shell extension DLLs via the custom action. Disable reboot prompt in case of the version with this change was previously already installed. #3178

Triggered via pull request March 19, 2024 12:56
@allexzanderallexzander
synchronize #6525
feature/msi-customaction-close-shellextensions
Status Success
Total duration 1m 33s
Artifacts –

clang-format.yml

on: pull_request
build
27s
build
Fit to window
Zoom out
Zoom in

Annotations

1 error, 10 warnings, and 2 notices
shell_integration/windows/NCContextMenu/dllmain.cpp:15:10 [clang-diagnostic-error]: shell_integration/windows/NCContextMenu/dllmain.cpp#L15
'windows.h' file not found
admin/win/tools/NCMsiHelper/CustomAction.cpp:99:6 [modernize-use-trailing-return-type]: admin/win/tools/NCMsiHelper/CustomAction.cpp#L99
use a trailing return type for this function
admin/win/tools/NCMsiHelper/CustomAction.cpp:101:11 [cppcoreguidelines-init-variables]: admin/win/tools/NCMsiHelper/CustomAction.cpp#L101
variable 'szFormatted' is not initialized
admin/win/tools/NCMsiHelper/CustomAction.cpp:103:13 [cppcoreguidelines-init-variables]: admin/win/tools/NCMsiHelper/CustomAction.cpp#L103
variable 'args' is not initialized
admin/win/tools/NCMsiHelper/CustomAction.cpp:108:16 [cppcoreguidelines-init-variables]: admin/win/tools/NCMsiHelper/CustomAction.cpp#L108
variable 'hRecord' is not initialized
admin/win/tools/NCMsiHelper/CustomAction.cpp:115:16 [modernize-use-trailing-return-type]: admin/win/tools/NCMsiHelper/CustomAction.cpp#L115
use a trailing return type for this function
admin/win/tools/NCMsiHelper/CustomAction.cpp:118:11 [cppcoreguidelines-init-variables]: admin/win/tools/NCMsiHelper/CustomAction.cpp#L118
variable 'windowClassNameSize' is not initialized
admin/win/tools/NCMsiHelper/CustomAction.cpp:133:24 [cppcoreguidelines-init-variables]: admin/win/tools/NCMsiHelper/CustomAction.cpp#L133
variable 'windowClassNameValue' is not initialized
admin/win/tools/NCMsiHelper/CustomAction.cpp:134:23 [cppcoreguidelines-init-variables]: admin/win/tools/NCMsiHelper/CustomAction.cpp#L134
variable 'vec' is not initialized
shell_integration/windows/NCContextMenu/dllmain.cpp:24:6 [cppcoreguidelines-avoid-non-const-global-variables]: shell_integration/windows/NCContextMenu/dllmain.cpp#L24
variable 'hHiddenWnd' is non-const and globally accessible, consider making it const
shell_integration/windows/NCContextMenu/dllmain.cpp:25:7 [cppcoreguidelines-avoid-non-const-global-variables]: shell_integration/windows/NCContextMenu/dllmain.cpp#L25
variable 'WINAPI' is non-const and globally accessible, consider making it const
Run clang-format on admin/win/tools/NCMsiHelper/CustomAction.cpp: admin/win/tools/NCMsiHelper/CustomAction.cpp#L1
File admin/win/tools/NCMsiHelper/CustomAction.cpp does not conform to Custom style guidelines. (lines 137, 138)
Run clang-format on src/libsync/vfs/cfapi/shellext/dllmain.cpp: src/libsync/vfs/cfapi/shellext/dllmain.cpp#L1
File src/libsync/vfs/cfapi/shellext/dllmain.cpp does not conform to Custom style guidelines. (lines 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114)