Skip to content

Feature/e2ee use hardware token secure storage #4551

Feature/e2ee use hardware token secure storage

Feature/e2ee use hardware token secure storage #4551

Triggered via pull request November 19, 2024 10:43
Status Success
Total duration 50s
Artifacts

clang-format.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors, 10 warnings, and 10 notices
src/gui/folder.cpp:16:10 [clang-diagnostic-error]: src/gui/folder.cpp#L16
'common/syncjournaldb.h' file not found
src/gui/accountsettings.cpp:1148:43 [bugprone-easily-swappable-parameters]: src/gui/accountsettings.cpp#L1148
2 adjacent parameters of 'showConnectionLabel' of similar type are easily swapped by mistake
src/gui/accountsettings.cpp:1528:23 [readability-convert-member-functions-to-static]: src/gui/accountsettings.cpp#L1528
method 'slotE2eEncryptionCertificateNeedMigration' can be made static
src/gui/accountsettings.cpp:1536:23 [readability-convert-member-functions-to-static]: src/gui/accountsettings.cpp#L1536
method 'updateBlackListAndScheduleFolderSync' can be made static
src/gui/systray.cpp:323:15 [readability-convert-member-functions-to-static]: src/gui/systray.cpp#L323
method 'createEncryptionTokenDiscoveryDialog' can be made static
src/gui/systray.cpp:341:15 [readability-convert-member-functions-to-static]: src/gui/systray.cpp#L341
method 'destroyEncryptionTokenDiscoveryDialog' can be made static
src/gui/systray.cpp:351:15 [modernize-use-trailing-return-type]: src/gui/systray.cpp#L351
use a trailing return type for this function
src/libsync/clientsideencryption.cpp:2906:1 [cppcoreguidelines-pro-type-member-init]: src/libsync/clientsideencryption.cpp#L2906
constructor does not initialize these fields: _privateKeyData, _certificate
src/libsync/clientsideencryption.cpp:2911:1 [cppcoreguidelines-pro-type-member-init]: src/libsync/clientsideencryption.cpp#L2911
constructor does not initialize these fields: _privateKeyData, _certificate
src/libsync/clientsideencryption.cpp:2919:1 [cppcoreguidelines-pro-type-member-init]: src/libsync/clientsideencryption.cpp#L2919
constructor does not initialize these fields: _privateKeyData, _certificate
Run clang-format on src/common/syncjournaldb.cpp: src/common/syncjournaldb.cpp#L1
File src/common/syncjournaldb.cpp does not conform to Custom style guidelines. (lines 51, 71, 994, 996)
Run clang-format on src/csync/csync.h: src/csync/csync.h#L1
File src/csync/csync.h does not conform to Custom style guidelines. (lines 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 157, 159, 160)
Run clang-format on src/gui/accountsettings.cpp: src/gui/accountsettings.cpp#L1
File src/gui/accountsettings.cpp does not conform to Custom style guidelines. (lines 295, 296, 297, 298)
Run clang-format on src/gui/accountsettings.h: src/gui/accountsettings.h#L1
File src/gui/accountsettings.h does not conform to Custom style guidelines. (lines 65)
Run clang-format on src/gui/filedetails/sharemodel.cpp: src/gui/filedetails/sharemodel.cpp#L1
File src/gui/filedetails/sharemodel.cpp does not conform to Custom style guidelines. (lines 604)
Run clang-format on src/gui/folder.cpp: src/gui/folder.cpp#L1
File src/gui/folder.cpp does not conform to Custom style guidelines. (lines 141)
Run clang-format on src/gui/owncloudgui.cpp: src/gui/owncloudgui.cpp#L1
File src/gui/owncloudgui.cpp does not conform to Custom style guidelines. (lines 150, 625)
Run clang-format on src/gui/settingsdialog.cpp: src/gui/settingsdialog.cpp#L1
File src/gui/settingsdialog.cpp does not conform to Custom style guidelines. (lines 225)
Run clang-format on src/gui/systray.cpp: src/gui/systray.cpp#L1
File src/gui/systray.cpp does not conform to Custom style guidelines. (lines 331)
Run clang-format on src/gui/systray.h: src/gui/systray.h#L1
File src/gui/systray.h does not conform to Custom style guidelines. (lines 199)