Clang Format Checker

Fix sync errors when trying to delete video component of live photos #4403

Sign in to view logs

Summary
Jobs
- build
Run details
- Usage
- Workflow file

Triggered via pull request October 30, 2024 08:01

claucambra

synchronize #7435

bugfix/live-photos-delete

Status Success

Total duration 46m 39s

Artifacts –

clang-format.yml

on: pull_request

Annotations

6 errors, 3 warnings, and 2 notices

src/common/syncjournaldb.cpp:19:10 [clang-diagnostic-error]: src/common/syncjournaldb.cpp#L19

'QCryptographicHash' file not found

src/common/syncjournalfilerecord.h:22:10 [clang-diagnostic-error]: src/common/syncjournalfilerecord.h#L22

'QString' file not found

src/libsync/discoveryphase.h:17:10 [clang-diagnostic-error]: src/libsync/discoveryphase.h#L17

'QObject' file not found

src/libsync/syncfileitem.h:18:10 [clang-diagnostic-error]: src/libsync/syncfileitem.h#L18

'QVector' file not found

test/syncenginetestutils.h:9:10 [clang-diagnostic-error]: test/syncenginetestutils.h#L9

'account.h' file not found

test/testlocaldiscovery.cpp:8:10 [clang-diagnostic-error]: test/testlocaldiscovery.cpp#L8

'QtTest' file not found

test/syncenginetestutils.cpp:226:16 [readability-convert-member-functions-to-static]: test/syncenginetestutils.cpp#L226

method 'setIsLivePhoto' can be made static

test/syncenginetestutils.cpp:233:16 [readability-convert-member-functions-to-static]: test/syncenginetestutils.cpp#L233

method 'modifyLockState' can be made static

test/syncenginetestutils.cpp:233:82 [bugprone-easily-swappable-parameters]: test/syncenginetestutils.cpp#L233

6 adjacent parameters of 'modifyLockState' of similar type are easily swapped by mistake

Run clang-format on src/common/syncjournaldb.cpp: src/common/syncjournaldb.cpp#L1

File src/common/syncjournaldb.cpp does not conform to Custom style guidelines. (lines 52, 971, 972, 973, 999, 1000)

Run clang-format on src/libsync/discovery.cpp: src/libsync/discovery.cpp#L1

File src/libsync/discovery.cpp does not conform to Custom style guidelines. (lines 550)