Merge pull request #147 from nextcloud/bugfix/fatal-int-error

Fix fatal error caused by wrong return type in sparkle update length
nextcloud · Jul 1, 2024 · 120a5b4 · 120a5b4
2 parents 6e52105 + 6a61f1c
commit 120a5b4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Response.php b/src/Response.php
@@ -126,7 +126,7 @@ private function getSparkleUpdateSignature(array $updateVersion) : string {
 		return $updateVersion[$updateSignatureKey];
 	}
 
-	private function getSparkleUpdateLength(array $updateVersion) : string {
+	private function getSparkleUpdateLength(array $updateVersion) : int {
 		$updateLengthKey = $this->isFileProvider ? 'fileProviderLength' : 'length';
 		return $updateVersion[$updateLengthKey];
 	}

diff --git a/tests/unit/ResponseTest.php b/tests/unit/ResponseTest.php
@@ -48,7 +48,7 @@ public function updateDataProvider(): array
 						'downloadurl' => 'https://download.owncloud.com/desktop/stable/ownCloud-2.2.2.3472.pkg',
 						'sparkleDownloadUrl' => 'https://download.owncloud.com/desktop/stable/ownCloud-2.2.2.3472.pkg.tbz',
 						'signature' => 'MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=',
-						'length' => '62738920',
+						'length' => 62738920,
 					]
 				],
 				'beta' => [
@@ -71,7 +71,7 @@ public function updateDataProvider(): array
 						'downloadurl' => 'https://download.nextcloud.com/desktop/stable/Nextcloud-2.2.2-rc2.pkg',
 						'sparkleDownloadUrl' => 'https://download.nextcloud.com/desktop/stable/Nextcloud-2.2.2-rc1.pkg.tbz',
 						'signature' => 'MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=',
-						'length' => '62738920',
+						'length' => 62738920,
 					]
 				],
 				'daily' => [