Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Download Limit Features #107

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

i2h3
Copy link
Contributor

@i2h3 i2h3 commented Nov 21, 2024

These changes mostly add features to enable management of share download limits as provided by the files_downloadlimit server app. This is required for #3184 of the iOS app.

@i2h3 i2h3 changed the base branch from main to develop November 21, 2024 14:09
@i2h3 i2h3 self-assigned this Nov 25, 2024
@tobiasKaminsky tobiasKaminsky linked an issue Nov 26, 2024 that may be closed by this pull request
@i2h3 i2h3 force-pushed the files_downloadlimit branch from 3f2abc9 to f2dabb2 Compare November 27, 2024 16:00
Copy link
Member

@marinofaggiana marinofaggiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Info requested

Sources/NextcloudKit/Models/NKFile.swift Show resolved Hide resolved
- Requesting share download limit capability of files_downloadlimit app.
- Augmented WebDAV metadata requests and responses with optional share download limits.
- Extended NextcloudKit with methods to manage share download limits via OCS.

Signed-off-by: Iva Horn <[email protected]>
@i2h3 i2h3 force-pushed the files_downloadlimit branch from e175406 to c094530 Compare December 16, 2024 09:55
@i2h3 i2h3 requested a review from marinofaggiana December 19, 2024 07:44
Copy link
Collaborator

@mpivchev mpivchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thanks for documentation, we need more of that

@i2h3 i2h3 removed the request for review from marinofaggiana December 20, 2024 09:25
@marinofaggiana marinofaggiana merged commit dd022b9 into develop Dec 20, 2024
4 checks passed
@marinofaggiana marinofaggiana deleted the files_downloadlimit branch December 20, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download Limit Support
3 participants