Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: breadcrumbs grow #987

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: breadcrumbs grow #987

merged 1 commit into from
Sep 7, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Sep 7, 2023

Before/after
Peek 07-09-2023 16-30

@skjnldsv
fix: breadcrumbs grow
01a0340 
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv added bug Something isn't working 3. to review labels Sep 7, 2023
@skjnldsv skjnldsv added this to the 5.0.0 milestone Sep 7, 2023
@skjnldsv skjnldsv requested a review from susnux September 7, 2023 14:31
@skjnldsv skjnldsv self-assigned this Sep 7, 2023
@skjnldsv skjnldsv requested review from artonge and Pytal September 7, 2023 14:31
artonge
artonge approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where was it overridden?

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Sep 7, 2023

Where was it overridden?

No clue, might depend on the loading order 🤔
Both are data-targeting attributes
image

@skjnldsv skjnldsv merged commit 6fb2a12 into master Sep 7, 2023
8 checks passed
@skjnldsv skjnldsv deleted the fix/breadcrubs branch September 7, 2023 14:55
@susnux
Copy link
Contributor

susnux commented Sep 7, 2023

Where was it overridden?

Vue library

@susnux susnux mentioned this pull request Sep 13, 2023
Merged
@Pytal Pytal mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @susnux @artonge