Fix styling issues and make the FilePicker height fixed #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make sure scrolled elements can not be seen through the table header * Ensure the buttons are not overlaying the files list content Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
changed the title
…g skeletons Signed-off-by: Ferdinand Thiessen <[email protected]>
skjnldsv
approved these changes
Aug 28, 2023
jancborchardt
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Looks good design-wise! But will this make it to 27.1 as mentioned in #900 (comment) @susnux @szaimen?
Edit: Ah I guess that's what the backport at #972 is for? Let's just make sure it gets in.
|
@jancborchardt If someone merges the open stable4 requests and creates a new beta release then we can try to merge on server until Thursday. |
|
@AndyScherzinger @skjnldsv is that possible? Otherwise the filepicker changes height often which looks very off. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some remaining styling issues and the second commit sets a fixed height to the file picker.
We already have a max. width of 900px and a max. height of 90% from the modal.
So from my perspective a height of max. 800px looks good (900x800px), thats why I set the height to
min(80vh, 800px).