Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable4] fix(deps): bump @nextcloud/files to 3.0.0 #1347

Closed
wants to merge 1 commit into from

Conversation

st3iny
Copy link

@st3iny st3iny commented Jun 4, 2024

The required @nextcloud/files dependency is broken and fixing this inside other apps is hacky because the package lock has to be adjusted manually. It would be nice to release a 4.x.x version with the fixed dependency to make it easier to fix downstream.

Note that simply adding @nextcloud/files as a dependency to an app's package.json does not work because it is not a peer of @nextcloud/dialogs. Thus, npm will just install both versions separately.

E.g. in Deck:

@nextcloud/[email protected]
node_modules/@nextcloud/dialogs/node_modules/@nextcloud/files
  @nextcloud/files@"3.0.0-beta.21" from @nextcloud/[email protected]
  node_modules/@nextcloud/dialogs
    @nextcloud/dialogs@"^4.2.2" from the root project

@nextcloud/[email protected]
node_modules/@nextcloud/files
  @nextcloud/files@"^3.0.0" from the root project

Ref

Exemplary (hacky) downstream fix at nextcloud/calendar#6035

@st3iny st3iny added bug Something isn't working dependencies Pull requests that update a dependency file 3. to review labels Jun 4, 2024
@st3iny st3iny requested review from susnux and Pytal June 4, 2024 06:23
@st3iny st3iny self-assigned this Jun 4, 2024
@st3iny st3iny changed the title fix(deps): bump @nextcloud/files to 3.0.0 [stable4] fix(deps): bump @nextcloud/files to 3.0.0 Jun 4, 2024
@susnux
Copy link
Contributor

susnux commented Jun 4, 2024

No this will break server on Nextcloud 27!

stable4 is only intended to be used with Nextcloud <= 27.
If you need to support a wider range please use v5 which also will work with Nextcloud 28+ and probably even 27.

@susnux susnux closed this Jun 4, 2024
@susnux susnux deleted the fix/deps/nextcloud-files-3.0.0 branch June 4, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants