Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global toastify options #380

Open
PVince81 opened this issue Jun 18, 2021 · 2 comments
Open

Global toastify options #380

PVince81 opened this issue Jun 18, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@PVince81
Copy link
Contributor

Make it possible to set toastify options globally so that one doens't need to pass in the same options everywhere.

One use case would be to pass in an offset for apps that have a top bar, see nextcloud/spreed#5794
or even to switch to bottom aligned notifications for some layouts.

@ChristophWurst
Copy link
Contributor

I'm fine if it's something stateless without side effects, e.g. like we did with https://github.com/nextcloud/nextcloud-logger#usage.

@nickvergessen
Copy link
Contributor

I'm fine if it's something stateless without side effects, e.g. like we did with https://github.com/nextcloud/nextcloud-logger#usage.

That will not quite cut it for Talk at least:

  • Talk allows to "fullscreen" the Talk area (video call area + right sidebar)
  • If that is done, any showError() from viewer, editors, sharing, talk, deck, tasks and other apps that integrate with the Talk UI, must not be mounted on body or whatever, but Talk needs to be able to define this, without the other apps having to adjust their code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants