Step2 #3254
Open
Step2 #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javajigi
requested changes
May 26, 2023
Comment on lines
+16
to
+17
| ResultView resultView = new ResultView(); | ||
| InputView inputView = new InputView(); |
There was a problem hiding this comment.
상태 값을 가지지 않는데 굳이 인스턴스를 생성할 필요가 있을까?
클래스 메서드(static)로 구현해도 되지 않을까?
Comment on lines
+26
to
+28
| List<Rank> ranks = lottos.stream() | ||
| .map(lotto -> lotto.getRank(winningLotto.getWinningLottoNums())) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
Lottos와 같은 일급 콜렉션을 만들고 이 객체에 이 로직을 위임하는 것은 어떨까?
List<Rank> ranks = lottos.match(winningLotto);
또는 아래에 있는 Winnings winnings = lottos.match(winningLotto);를 반환하고, Winnings가 List를 상태 값으로 가지는 것도 좋지 않을까?
| @@ -0,0 +1,28 @@ | |||
| package step2.domain; | |||
|
|
|||
| public class Amount { | |||
|
|
||
| private final int amount; | ||
|
|
||
| public Amount(int amount) { |
There was a problem hiding this comment.
amount 값에 대한 유효성 체크를 이 생성자에서 진행하는 것은 어떨까?
Comment on lines
+4
to
+6
| public static final int MIN_NUM = 1; | ||
| public static final int MAX_NUM = 45; | ||
| public static final int LOTTO_NUM_SIZE = 6; |
There was a problem hiding this comment.
이 상수들은 Lotto 또는 LottoNums와 같이 관련 있는 곳에 위치하는 것은 어떨까?
|
|
||
| public LottoNum(int num) { | ||
| this.num = num; | ||
| validateLottoNum(); |
Comment on lines
+37
to
+43
| LottoNums lottoNums = new LottoNums(new LottoNums.Builder() | ||
| .lottoNum(new LottoNum(1)) | ||
| .lottoNum(new LottoNum(2)) | ||
| .lottoNum(new LottoNum(16)) | ||
| .lottoNum(new LottoNum(19)) | ||
| .lottoNum(new LottoNum(30)) | ||
| .lottoNum(new LottoNum(32))); |
There was a problem hiding this comment.
Suggested change
| LottoNums lottoNums = new LottoNums(new LottoNums.Builder() | |
| .lottoNum(new LottoNum(1)) | |
| .lottoNum(new LottoNum(2)) | |
| .lottoNum(new LottoNum(16)) | |
| .lottoNum(new LottoNum(19)) | |
| .lottoNum(new LottoNum(30)) | |
| .lottoNum(new LottoNum(32))); | |
| LottoNums lottoNums = new LottoNums(1, 2, 16, 19, 30, 32); |
위와 같이 생성할 수 있는 생성자를 추가하는 것은 어떨까?
Comment on lines
+45
to
+51
| List<LottoNum> lottoNumList = new ArrayList<>(); | ||
| lottoNumList.add(new LottoNum(1)); | ||
| lottoNumList.add(new LottoNum(2)); | ||
| lottoNumList.add(new LottoNum(16)); | ||
| lottoNumList.add(new LottoNum(19)); | ||
| lottoNumList.add(new LottoNum(30)); | ||
| lottoNumList.add(new LottoNum(32)); |
There was a problem hiding this comment.
Suggested change
| List<LottoNum> lottoNumList = new ArrayList<>(); | |
| lottoNumList.add(new LottoNum(1)); | |
| lottoNumList.add(new LottoNum(2)); | |
| lottoNumList.add(new LottoNum(16)); | |
| lottoNumList.add(new LottoNum(19)); | |
| lottoNumList.add(new LottoNum(30)); | |
| lottoNumList.add(new LottoNum(32)); | |
| List<LottoNum> lottoNumList = Arrays.asList( | |
| new LottoNum(1), new LottoNum(2), new LottoNum(16), new LottoNum(19), new LottoNum(30), new LottoNum(32); |
테스트 코드에 List를 생성할 때 Arrays 사용하면 유용한 경우 많다.
| WinningLotto winningLotto = new WinningLotto(lottoNums); | ||
| assertThat(lotto.getRank(winningLotto.getWinningLottoNums())).isEqualTo(new Rank(6)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Rank를 구하는 테스트 코드도 추가해 보는 것은 어떨까?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
많이 늦었네요... 잘 부탁드립니다