[전남대 Android_최영빈] 미션 제출합니다. #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a list of features.
Extract part of onCreate into a new function
Alternating placement of black and white stones
Allow placing stones only on empty spaces
Extract part of isPositionEmpty into a new function
a new function which concurrently executes checkHorizontal, checkVertical, and checkDiagonal functions
Refector checkWin function/ Delete checkHorizontal,checkVertical,checkDiagonal function
This reverts commit f6faf58.
This reverts commit 36466a5.
This reverts commit d1ddd25.
This reverts commit d69cb49.
This reverts commit 87a3ee4.
Addtional, update checkVertical function parameters
for use checkState function
1. Change checkVertical function parameters for use checkState function 2. Use parentheses to clarify logical expression
This reverts commit bc25ee4.
- to handle checkState, checkVertical, checkHorizontal, and checkDiagonal functions - for improve code readability and test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 2차 미니 과제