Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(key_transaction): add new resource to manage key transactions #2748

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

vagrawal-newrelic
Copy link
Contributor

@vagrawal-newrelic vagrawal-newrelic commented Sep 25, 2024

Description

Please include a summary of the change and which issue is fixed (if relevant).

Added key transaction support in terraform.
to understand what is key transaction refer to this

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

Create a new Key transaction
update the key transaction
delete the key transaction

@pranav-new-relic
Copy link
Member

pranav-new-relic commented Sep 25, 2024

@vagrawal-newrelic please address the lint failures we're seeing with _, err := statements needed with d.Set and d.Get

@pranav-new-relic pranav-new-relic changed the title feat(key transaction): add support for key transaction feat(key_transaction): add new resource to manage key transactions Sep 25, 2024
@pranav-new-relic pranav-new-relic force-pushed the NR-313469-key_transaction branch from 4dd712e to b01a53c Compare September 25, 2024 19:13
@pranav-new-relic pranav-new-relic merged commit c237c0b into main Sep 25, 2024
13 of 14 checks passed
@pranav-new-relic pranav-new-relic deleted the NR-313469-key_transaction branch September 25, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants