feat: add support for tags to the newrelic_entity data source
#2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav-new-relic
force-pushed
the
NR-273644
branch
from
cae75e4 to
19981a9
Compare
pranav-new-relic
changed the title
newrelic_entity data source
|
All other failures in integration tests seem to be expected because of latency, except
and these aren't working because the entity they're using in the referenced account no longer exists. I've just replenished the entity, and both of these tests shouldn't be failing from the next run. |
|
Replenished the dead entity again; rerunning integration tests |
pranav-new-relic
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data_source_newrelic_entity
Fixes # issue-2666
In the GitHub issue linked above, it has been reported as feedback from a customer that the
newrelic_entitydata source in the New Relic Terraform Provider currently does not return the tags of the entity fetched. This PR will add support fortagsto thedata_source_newrelic_entity