chore: Refactored sql parser #2714
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2714 +/- ##
==========================================
- Coverage 97.24% 97.23% -0.02%
==========================================
Files 294 293 -1
Lines 46125 46412 +287
==========================================
+ Hits 44855 45128 +273
- Misses 1270 1284 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
force-pushed
the
issue-2703
branch
from
5279da9
to
1850f48
Compare
jsumners-nr
added
the
risk: medium
|
Looking at the benchmarks this is slightly slower |
Which is why I haven't really pushed it. We need a replication of the original issue to learn if the cost is worth it. |
|
Ag
Agreed. I think if there's an actual issue and this fixes it, it may be worth investigating. Until we get a repro I don't see the value add in this PR |
This PR is meant to resolve #2703. Basically, it removes the complicated regular expressions in favor of a more procedural parsing of SQL statements. All cross-application tests pass.
main branch benchmark
{ "lib/db/query-parsers/sql.bench.js": { "leading-multi-line-comment-single-line": { "numSamples": 199800, "mean": 0.0013976976977020214, "stdDev": 0.0014156655019840908, "max": 0.085, "min": 0, "5thPercentile": 0.001, "95thPercentile": 0.002, "median": 0.001 }, "leading-multi-line-comment-multiple-lines": { "numSamples": 199800, "mean": 0.0013618468468510846, "stdDev": 0.0006465917362843219, "max": 0.015, "min": 0, "5thPercentile": 0.001, "95thPercentile": 0.002, "median": 0.001 }, "single-embedded-multi-line-comment": { "numSamples": 199800, "mean": 0.0013247097097138071, "stdDev": 0.0006047642355391195, "max": 0.016, "min": 0, "5thPercentile": 0.001, "95thPercentile": 0.002, "median": 0.001 }, "multiple-embedded-multi-line-comments": { "numSamples": 199800, "mean": 0.0015002302302342982, "stdDev": 0.0007180428487002329, "max": 0.016, "min": 0.001, "5thPercentile": 0.001, "95thPercentile": 0.002, "median": 0.001 }, "select-statement": { "numSamples": 199800, "mean": 0.0011379929929963577, "stdDev": 0.0004575930149290276, "max": 0.008, "min": 0, "5thPercentile": 0.001, "95thPercentile": 0.002, "median": 0.001 }, "update-statement": { "numSamples": 199800, "mean": 0.0012941541541581323, "stdDev": 0.0006351718693039712, "max": 0.029, "min": 0, "5thPercentile": 0.001, "95thPercentile": 0.002, "median": 0.001 }, "delete-statement": { "numSamples": 199800, "mean": 0.0012659209209248082, "stdDev": 0.0005621189869591081, "max": 0.018, "min": 0, "5thPercentile": 0.001, "95thPercentile": 0.002, "median": 0.001 } } }pr branch benchmark
{ "lib/db/query-parsers/sql.bench.js": { "leading-multi-line-comment-single-line": { "numSamples": 199800, "mean": 0.003716836836836951, "stdDev": 0.0035813356124759044, "max": 0.213, "min": 0.002, "5thPercentile": 0.003, "95thPercentile": 0.005, "median": 0.003 }, "leading-multi-line-comment-multiple-lines": { "numSamples": 199800, "mean": 0.0036585835835863433, "stdDev": 0.002235811989192826, "max": 0.113, "min": 0.002, "5thPercentile": 0.003, "95thPercentile": 0.005, "median": 0.003 }, "single-embedded-multi-line-comment": { "numSamples": 199800, "mean": 0.003405565565561924, "stdDev": 0.0020176129007566826, "max": 0.108, "min": 0.002, "5thPercentile": 0.003, "95thPercentile": 0.004, "median": 0.003 }, "multiple-embedded-multi-line-comments": { "numSamples": 199800, "mean": 0.003568348348350056, "stdDev": 0.001097445926842406, "max": 0.057, "min": 0.002, "5thPercentile": 0.003, "95thPercentile": 0.005, "median": 0.003 }, "select-statement": { "numSamples": 199800, "mean": 0.0017923973974009314, "stdDev": 0.0007276116250456387, "max": 0.025, "min": 0.001, "5thPercentile": 0.001, "95thPercentile": 0.002, "median": 0.002 }, "update-statement": { "numSamples": 199800, "mean": 0.0033950950950900212, "stdDev": 0.002676351775238991, "max": 0.14, "min": 0.002, "5thPercentile": 0.003, "95thPercentile": 0.004, "median": 0.003 }, "delete-statement": { "numSamples": 199800, "mean": 0.003193493493486407, "stdDev": 0.0012386411666348246, "max": 0.059, "min": 0.002, "5thPercentile": 0.002, "95thPercentile": 0.004, "median": 0.003 } } }