Skip to content

Commit

Permalink
EXT-SERVICE: match on service.name (#210)
Browse files Browse the repository at this point in the history
* EXT-SERVICE: match on service.name

Restoring an original rule that matched based on the pressence of the
attribute.  Added a warning to note that this rule matches too broadly
in some instrumentation sources, and we're ignoring in certain ingestion
paths until we add a configuration in rules that allows selecting the
right ingest paths to apply it.

Signed-off-by: Galo Navarro <[email protected]>

* Update definitions/ext-service/definition.yml

Co-authored-by: Jonathan Gordon <[email protected]>

Co-authored-by: Cian Buckley <[email protected]>
Co-authored-by: Jonathan Gordon <[email protected]>
  • Loading branch information
3 people authored May 17, 2021
1 parent 7335961 commit c76f4f0
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions definitions/ext-service/definition.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,27 @@ synthesis:
k8s.namespace.name:
entityTagName: k8s.namespaceName

# IMPORTANT:
# This rule matches on any telemetry with service.name
# which is too broad for some telemetry sources, resulting
# in matches that are not actually about services. We're
# keeping it for backwards compatibility reasons but it
# is being ignored in some internal services while we add
# a configuration option to choose the relevant ingestion
# sources for each rule.
- identifier: service.name
name: service.name
encodeIdentifierInGUID: true
conditions:
- attribute: service.name
tags:
telemetry.sdk.name:
entityTagName: instrumentation.provider
telemetry.sdk.language:
entityTagName: language
telemetry.sdk.version:


compositeMetrics:
goldenMetrics:
- golden_metrics.yml
Expand Down

0 comments on commit c76f4f0

Please sign in to comment.