Skip to content

Commit

Permalink
Fix error metrics for Pixie service entities. (#200)
Browse files Browse the repository at this point in the history
  • Loading branch information
Frederick Ryckbosch authored May 4, 2021
1 parent 759b731 commit 24a0a88
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion definitions/ext-service/golden_metrics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ errorRate:
select: (filter(sum(http.server.requests), where exception IS NOT NULL and exception != 'None') * 100) / sum(http.server.requests)
from: Metric
pixie:
select: (filter(count(http.server.duration), where http.status_code >= 400 AND http.status_code != 404) * 100) / count(http.server.duration)
select: (filter(count(http.server.duration), where numeric(http.status_code) >= 400 AND numeric(http.status_code) != 404) * 100) / count(http.server.duration)
from: Metric
responseTimeMs:
title: Response time (ms)
Expand Down
2 changes: 1 addition & 1 deletion definitions/ext-service/summary_metrics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ errorRate:
from: Metric
eventId: entity.guid
pixie:
select: filter(count(http.server.duration), where http.status_code >= 400 AND http.status_code != 404) / count(http.server.duration) * 100
select: filter(count(http.server.duration), where numeric(http.status_code) >= 400 AND numeric(http.status_code) != 404) / count(http.server.duration) * 100
from: Metric
eventId: entity.guid
responseTimeMs:
Expand Down

0 comments on commit 24a0a88

Please sign in to comment.