Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a vendored lodash dependency, but it's only used in three unimportant places and contains an eval call. I think it would make sense to remove it.
The only things it's used for are:
fix_autoplaying_yanked_videos
/fix_jk_scrolling
in XKit Patches, injected functions that are already conditional on lodash's existence (and that, I assume, do nothing now). Not changed.const {keyToCss, descendantSelector} = XKit.css_map
), which is sugar and is only used in Fresh Prince. Function call removed in xkit.js and not changed in the XKit Patches entry for v7.9.2 for the above reason; destructuring removed in Fresh Prince, which should technically be deployed to v7.9.2 in advance for seamless upgrade experience, but it's Fresh Prince, so it's really not worth bothering (the hypothetical daily Fresh Prince user will be automatically updated by XKit Update shortly after installing v7.10.0 and they can manually update earlier if they really want).