Fix long form of --output option

neverpanic · May 31, 2018 · 352849b · 352849b
1 parent 078b723
commit 352849b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/google-font-download b/google-font-download
@@ -143,7 +143,7 @@ fi
 # Parse options
 if [ $modern_getopt -eq 1 ]; then
 	ret=0
-	temp=$(getopt -o u:f:hl:o: --long url:,format:,help,languages:,output -n "${0:-google-font-download}" -- "$@") || ret=$?
+	temp=$(getopt -o u:f:hl:o: --long url:,format:,help,languages:,output: -n "${0:-google-font-download}" -- "$@") || ret=$?
 	if [ $ret -ne 0 ]; then
 		echo >&2
 		usage

diff --git a/test/Makefile b/test/Makefile
@@ -1,4 +1,4 @@
-TESTS=eot svg ttf woff woff2 fonts-with-spaces multiple-fonts format-param output-param font-weight font-style url-arg
+TESTS=eot svg ttf woff woff2 fonts-with-spaces multiple-fonts format-param output-param output-long-param font-weight font-style url-arg
 TUT=../../google-font-download
 
 # tests use bashisms, avoid failures on systems where dash is used
@@ -64,6 +64,11 @@ output-param:
 	$(V)mkdir -p $@ && (cd $@ && $(TUT) -f woff -o "other.css" "Lora" && [ -f "other.css" ] && [ ! -f "font.css" ]); ret=$$?; rm -rf $@ && exit $$ret
 	$(V)echo "     OK"
 
+output-long-param:
+	$(V)echo "---> Testing that --output works as expected"
+	$(V)mkdir -p $@ && (cd $@ && $(TUT) -f woff --output="other.css" "Lora" && [ -f "other.css" ] && [ ! -f "font.css" ]); ret=$$?; rm -rf $@ && exit $$ret
+	$(V)echo "     OK"
+
 font-weight:
 	$(V)echo "---> Testing font weight support"
 	$(V)mkdir -p $@ && (cd $@ && $(TUT) -f woff "Ubuntu:300" && grep "font-weight: 300;" "font.css" >/dev/null); ret=$$?; rm -rf $@ && exit $$ret