Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Template refactor #281

Merged
merged 35 commits into from
Jul 7, 2022
Merged

[wip] Template refactor #281

merged 35 commits into from
Jul 7, 2022

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Jun 16, 2022 •
edited
Loading

Description

Doing some refactoring. Main ideas:

  • Less copy pasta
  • More flexibility

Details

  • stop using [string, string] for seed / actual id
  • move some stuff to conditions (generate condition based on DDO etc.)
  • agreement template implementations should become much smaller
  • TODO: fulfilling based on condition instance data
  • TODO: check if there's some way to use typescript better

Is this PR related with an open issue?

Related to Issue #285

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@mrsmkl mrsmkl requested review from a team as code owners June 16, 2022 14:10
@mrsmkl mrsmkl changed the title Template refactor [wip] Template refactor Jun 16, 2022
mrsmkl added 24 commits June 21, 2022 13:33
@mrsmkl
fulfill condition instances
c5ccef8
@mrsmkl
converting access proof template
65616cc
@mrsmkl
compute template
4c77aac
@mrsmkl
nft access template
9bc2cd3
@mrsmkl
nft sales template
136ac49
@mrsmkl
first typing
7376f6f
@mrsmkl
improved typing
aa40610
@mrsmkl
clean up
625ce4d
@mrsmkl
added types to nft conditions
6436aa0
@mrsmkl
added types to templates
1a6eadd
@mrsmkl
converted aave conditions
3646d8d
@mrsmkl
converted aave template
ac2334b
@mrsmkl
compiles
bac7ebb
@mrsmkl
Merge branch 'master' of github.com:nevermined-io/sdk-js into feat/te…
9d899e1 
…mplate-refactor
@mrsmkl
unit tests mostly working
ad5009f
@mrsmkl
integration tests compiled
3beb2ab
@mrsmkl
integration tests compile
4cd31b4
@mrsmkl
first tests working
e530f08
@mrsmkl
first tests working
42dca23
@mrsmkl
most tests working
6a159b4
@mrsmkl
secondary market working
088e63f
@mrsmkl
lint
26a9886
@mrsmkl
refactor fulfilling escrow conditions for nfts
30ae9dc
@mrsmkl
refactored fulfilling transfer conditions
06923e5
r-marques
r-marques approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@r-marques r-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aaitor aaitor linked an issue Jul 7, 2022 that may be closed by this pull request
Refactor how to manage templates in the sdk-js #295
Closed
@r-marques r-marques merged commit 4b9a002 into master Jul 7, 2022
@r-marques r-marques deleted the feat/template-refactor branch July 7, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-marques r-marques r-marques approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor how to manage templates in the sdk-js
2 participants
@mrsmkl @r-marques