Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of compute API #83

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Definition of compute API #83

wants to merge 22 commits into from

Conversation

aaitor
Copy link
Member

@aaitor aaitor commented Nov 28, 2022

Description

Add a description of your changes here.

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

@aaitor aaitor marked this pull request as ready for review December 16, 2022 14:25
@aaitor aaitor requested review from a team as code owners December 16, 2022 14:25
Comment on lines +222 to +226
// DUMMY_SEED_WORDS,
// config.nvm.web3ProviderUri,
// 0,
// 1
// )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup

Comment on lines +207 to +212
// hdWalletProvider = new HDWalletProvider(
// config.seed!,
// config.nvm.web3ProviderUri,
// accountIndex,
// 10
// )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup

Comment on lines +190 to +198
// hdWalletProvider = new HDWalletProvider(
// [
// getPrivateKey(
// process.env.KEYFILE_PATH!,
// process.env.KEYFILE_PASSWORD!
// )
// ],
// config.nvm.web3ProviderUri
// )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants