Skip to content

Commit

Permalink
ci: reordering workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
aaitor committed Oct 6, 2023
1 parent 65cd6e8 commit 59dfeba
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
17 changes: 10 additions & 7 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ jobs:
yarn
- name: Run linters
run: yarn lint
- name: Build
run: |
yarn build
yarn start --help

- uses: nevermined-io/[email protected]
with:
Expand All @@ -42,15 +38,22 @@ jobs:
nvm-tools copy-circuits /tmp/.nevermined/circuits
ls -l /tmp/.nevermined/circuits/keytransfer.wasm
- name: Build
run: |
yarn build
yarn start --help
- name: Run integration tests
env:
LOCAL_CONF_DIR: '/tmp/.nevermined'
SEED_WORDS: ${{ secrets.TEST_MNEMONIC }}
INFURA_TOKEN: ${{ secrets.INFURA_TOKEN }}
IPFS_PROJECT_ID: ${{ secrets.IPFS_PROJECT_ID }}
IPFS_PROJECT_SECRET: ${{ secrets.IPFS_PROJECT_SECRET }}
LOCAL_CONF_DIR: '/tmp/.nevermined'
TOKEN_ADDRESS: '0x0000000000000000000000000000000000000000'
WEB3_PROVIDER_URL: 'http://contracts.nevermined.localnet'
NETWORK: 'geth-localnet'
IPFS_PROJECT_ID: ${{ secrets.IPFS_PROJECT_ID }}
IPFS_PROJECT_SECRET: ${{ secrets.IPFS_PROJECT_SECRET }}

run: |
yarn test:integration
- name: Upload logs
Expand Down
7 changes: 2 additions & 5 deletions src/commands/nfts/deployNft.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,18 @@ export const deployNft = async (
config: ConfigEntry,
logger: Logger
): Promise<ExecutionOutput> => {
const { account, abiPath } = argv
const { abiPath } = argv

const nftType = Number(argv.nftType)

logger.info(chalk.dim('Deploying NFT contract...'))

// const web3 = Web3Provider.getWeb3(config.nvm)

logger.debug(chalk.dim(`Using creator: '${creatorAccount.getId()}'\n`))

const content = fs.readFileSync(abiPath)
const artifact = JSON.parse(content.toString())

const signer = await nvm.web3.getSigner(account)
// const signer = await (await web3).getSigner(account)
const signer = config.signer
const contract = new ethers.ContractFactory(
artifact.abi,
artifact.bytecode,
Expand Down

0 comments on commit 59dfeba

Please sign in to comment.