Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use neutronjs in sdk47 #ntrn-147 #244

Merged
merged 89 commits into from
Dec 8, 2023
Merged

feat: use neutronjs in sdk47 #ntrn-147 #244

merged 89 commits into from
Dec 8, 2023

Conversation

NeverHappened
Copy link
Contributor

@NeverHappened NeverHappened commented Nov 23, 2023 •
edited
Loading

https://hadronlabs.atlassian.net/browse/NTRN-147

What's done:

  1. Uses buf to generate protobuf generated files
  2. Moved all newer sdk47 branch code for sdk47 into neutronjs
  3. Removed all helper's code from integration tests

Integration tests: #244
NeutronJS: neutron-org/neutronjsplus#11

albertandrejev and others added 30 commits September 8, 2023 13:03
@albertandrejev
user helpers from neutronjs package
e13e047
@albertandrejev
Update dao tests
faf46b4
@albertandrejev
Move part of the tests to new helpers repo
b247e58
@albertandrejev
Update tests
67172ae
@albertandrejev
fixes
edf93f2
@albertandrejev
Update test with new package
728d58c
@albertandrejev
fix wrong call
f55cfa8
@albertandrejev
Remove not used code
b18a656
@albertandrejev
Change development flow
042616e
@albertandrejev
change neutronjs to neutronjsplus package name
761ec30
@albertandrejev
fix helpers usage
93c2d4f
@albertandrejev
fix tests
bcad27d
@albertandrejev
fix lint errors
e1dc85d
@albertandrejev
upgrade neutronjsplus version
db69b56
@albertandrejev
Add missed import
17d590b
@albertandrejev
Fix import
393ab17
@albertandrejev
Fix import
599df0e
@albertandrejev
Fix imports
630c795
@albertandrejev
and another one import fix
98a761c
@albertandrejev
Fix code after rebase
e285396
@pr0n00gler
Merge pull request #185 from neutron-org/feat/extract-helpers-neutronjs
f5e9e35 
Move infrastructure helpers to package
@sotnikov-s
add voting registry test
e7fe7ed
@sotnikov-s
add voting registry test to package.json
522289f
@sotnikov-s
replace local imports with neutronjsplus for voting registry test
6a71740
@sotnikov-s
increase bond amount for gov test dao members
57309bf
@sotnikov-s
Merge branch 'chore/adapt-dao-tests-to-new-vault' of github.com:neutr…
462007d 
…on-org/neutron-integration-tests into feat/add-new-voting-registry-tests
@sotnikov-s
describe expected total voting power
889fca4
@sotnikov-s
describe expected total voting power
22cba19
@sotnikov-s
add pause between vault add and VP check and adapt VP checks
234e781
@sotnikov-s
decrease bond amount for dao members
639d39f
@NeverHappened NeverHappened marked this pull request as ready for review November 28, 2023 14:33
@NeverHappened
Copy link
Contributor Author

Testrun: https://github.com/neutron-org/neutron-tests/actions/runs/7020210258

@NeverHappened
Copy link
Contributor Author

https://github.com/neutron-org/neutron-tests/actions/runs/7046159446

pr0n00gler
pr0n00gler approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@pr0n00gler pr0n00gler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

quasisamurai
quasisamurai approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@quasisamurai quasisamurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NeverHappened
Copy link
Contributor Author

added parameters to the test:run_in_band
https://github.com/neutron-org/neutron-tests/actions/runs/7113325728/job/19365568183

@pr0n00gler pr0n00gler merged commit a1da4e8 into feat/upd-47 Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swelf19 swelf19 swelf19 approved these changes

@sotnikov-s sotnikov-s sotnikov-s approved these changes

@quasisamurai quasisamurai quasisamurai approved these changes

@pr0n00gler pr0n00gler pr0n00gler approved these changes

Assignees

@NeverHappened NeverHappened

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NeverHappened @pr0n00gler @quasisamurai @sotnikov-s @swelf19 @albertandrejev