feat: chainmanager globalfee dynamicfee ccv params #NTRN-408 #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2024
Merged
|
Attach successful test run please |
joldie777
previously approved these changes
Nov 21, 2024
sotnikov-s
requested changes
Nov 25, 2024
| consumer_redistribution_fraction: true, | ||
| historical_entries: true, | ||
| unbonding_period: true, | ||
| // !!! DEPRECATED !!! soft_opt_out_threshold is deprecated. see docs/docs/adrs/adr-015-partial-set-security.md |
There was a problem hiding this comment.
I think this comment is not necessary in this context
sotnikov-s
approved these changes
Nov 27, 2024
joldie777
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PR, tests for the chainmanager have been added to modify the parameters of the consumer, dynamicfees, and globalfee modules, to verify the correctness of the contract and the new permissions for modifying the module parameters.
Task definition: Add updateParamsPersimmon to chain manager (https://github.com/neutron-org/neutron-dao/tree/main/contracts/dao/neutron-chain-manager) for the following modules:
All prs:
neutron-org/neutronjs#10
neutron-org/neutronjsplus#69
#368
neutron-org/neutron-dao#116
neutron-org/neutron-std#8
neutron-org/neutron#765