Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chainmanager globalfee dynamicfee ccv params #NTRN-408 #116

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

swelf19
Copy link
Contributor

@swelf19 swelf19 commented Nov 15, 2024

In this PR:

  • New permissions have been added to modify the parameters of the consumer, dynamicfee, and globalfee modules.
  • A small refactor has been performed: files containing types and auxiliary code for the cron, adminmodule, tokenfactory, and dex modules were removed in favor of the code from neutron-std, which is automatically generated.
  • Hardcoded type_url/query_path strings have been removed in favor of defined by the messages/queries ones
  • A downgrade of Rust from version 1.78 to 1.75 has been performed. The reason is that cosmwasm-std version 1.5.2 (dealloc error with dlmalloc >= 2.5 CosmWasm/cosmwasm#2061), which is specified as a dependency in many packages, is incompatible with Rust 1.78. When trying to initialize a contract written with cosmwasm-std 1.5.2 and Rust 1.78, an error occurs.
  panic: genesis: Error calling the VM: Error executing Wasm: Wasmer runtime error: RuntimeError: Aborted: panicked at /rust/deps/dlmalloc-0.2.6/src/dlma  
lloc.rs:1198:13:
assertion failed: psize <= size + max_overhead: wasmvm error

TODO
We need to refactor the dependencies, and then we will be able to easily use the latest versions of Rust.

Task definition: Add updateParamsPersimmon to chain manager (https://github.com/neutron-org/neutron-dao/tree/main/contracts/dao/neutron-chain-manager) for the following modules:

  • consumer
  • dynamicfees
  • globalfee

All prs:
neutron-org/neutronjs#10
neutron-org/neutronjsplus#69
neutron-org/neutron-integration-tests#368
#116
neutron-org/neutron-std#8
neutron-org/neutron#765

Copy link
Contributor

@quasisamurai quasisamurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it could be out of scope, but what are our plans for covering ibc-rate-limit params?

.github/workflows/build.yml Show resolved Hide resolved
contracts/dao/neutron-chain-manager/src/msg.rs Outdated Show resolved Hide resolved
contracts/dao/neutron-chain-manager/src/msg.rs Outdated Show resolved Hide resolved
contracts/dao/neutron-chain-manager/src/msg.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants