Cma update tutorial template #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamzoltan
reviewed
Jan 9, 2024
Comment on lines
+413
to
418
| "# @title Video 1: Video 1 Name # put in the title of your video\n", | ||
| "# note the libraries are imported here on purpose\n", | ||
| "\n", | ||
| "###@@@ for konstanine. a question, why isn't this above in the list of cells? \n", | ||
| "\n", | ||
| "from ipywidgets import widgets\n", |
There was a problem hiding this comment.
what do you mean exactly?
|
It seems we are getting an error because the repo is not aware for the forked repos branch |
|
before the first cell, there is a list cells and their content.
the cell for video is not part of that list. it should be, as I believe all
days and tutorials should have a video.
…--------------------------------------------------------------------------------------------
"Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind" ------ Dr. Seuss
On Tue, Jan 9, 2024 at 2:02 AM Zoltan ***@***.***> wrote:
***@***.**** commented on this pull request.
good additions! if the workflow completes successfully, we can merge and
build
------------------------------
In tutorials/W1D2_Template/W1D2_Tutorial1.ipynb
<#14 (comment)>
:
> + "# @title Video 1: Video 1 Name # put in the title of your video\n",
+ "# note the libraries are imported here on purpose\n",
+ "\n",
+ "###@@@ for konstanine. a question, why isn't this above in the list of cells? \n",
+ "\n",
"from ipywidgets import widgets\n",
what do you mean exactly?
—
Reply to this email directly, view it on GitHub
<#14 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZL7YAWHBFNHX2LESHYZ5UDYNSJLRAVCNFSM6AAAAABBPU7JM2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMJQGI2TGNBVGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@OhadZivan I believe that can be left out for the time being but could be nice for future revisions. The curriculum specialist will be in charge of putting videos into the tutorials before prepod so I think we'll be good for this year. They also have the examples from last years tutorials. Let's plan to take another pass over this when things are slower. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.